[GitHub] [airflow] kaxil commented on a change in pull request #15302: Emit error on duplicated DAG ID

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #15302:
URL: https://github.com/apache/airflow/pull/15302#discussion_r626659477



##########
File path: airflow/models/dagbag.py
##########
@@ -390,7 +406,17 @@ def _process_modules(self, filepath, mods, file_last_changed_on_disk):
     def bag_dag(self, dag, root_dag):
         """
         Adds the DAG into the bag, recurses into sub dags.
-        Throws AirflowDagCycleException if a cycle is detected in this dag or its subdags
+
+        :throws: AirflowDagCycleException if a cycle is detected in this dag or its subdags.
+        :throws: AirflowDagDuplicatedIdException if this dag or its subdags already exists in the bag.

Review comment:
       Shouldn't this be `:raises:` ?
   
   ```suggestion
           :raises: AirflowDagCycleException if a cycle is detected in this dag or its subdags.
           :raises: AirflowDagDuplicatedIdException if this dag or its subdags already exists in the bag.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org