You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/20 16:11:55 UTC
[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1339: feat: add domSelector and data for search-
guoqqqi opened a new pull request #1339:
URL: https://github.com/apache/apisix-dashboard/pull/1339
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
___
### New feature or improvement
- Describe the details and related test reports.
changed the search-route test, add domSelector and data
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1339: feat: add domSelector and data for search-route
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1339:
URL: https://github.com/apache/apisix-dashboard/pull/1339#discussion_r561447686
##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -17,8 +17,34 @@
/* eslint-disable no-undef */
context('Create and Search Route', () => {
+ const timeout = 500;
+ const data = {
Review comment:
data for testcases, LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1339: feat: add domSelector and data for search-route
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1339:
URL: https://github.com/apache/apisix-dashboard/pull/1339
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1339: feat: add domSelector and data for search-route
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1339:
URL: https://github.com/apache/apisix-dashboard/pull/1339#discussion_r561447686
##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -17,8 +17,34 @@
/* eslint-disable no-undef */
context('Create and Search Route', () => {
+ const timeout = 500;
+ const data = {
Review comment:
data for testcases, LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1339: feat: add domSelector and data for search-route
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1339:
URL: https://github.com/apache/apisix-dashboard/pull/1339
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org