You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/07/12 17:47:22 UTC
[GitHub] [trafficcontrol] shamrickus opened a new pull request, #6955: TP Use Correct Name in Role Put
shamrickus opened a new pull request, #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR fixes #6925
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Portal
## What is the best way to verify this PR?
Verify that a user is able to update a role through TP.
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
- master
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1183394928
> I _think_ the intention was to keep the role names immutable, but I'm totally on board with reversing that. As long as the `admin` role is immutable, which I believe it is, we should be fine.
that makes sense to me. admin name immutable, others mutable. if not, puts extra burden on operators of the system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ericholguin commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
ericholguin commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1183348556
> > I think names have been mutable, per this legacy query that exists above the new one
>
> This makes me more sure the new behavior is intentional, otherwise the existing query language would've been re-used to a greater extent. I could still be wrong, but we'd need to hunt down the original proposal/PR to be sure. If that was the author's intent but was never communicated - or we just don't like that behavior -, we could reverse the decision even if it was intentional.
@srijeet0406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1182807390
> is it possible to just fix both with this PR? TP and TO?
Yes it's certainly possible, but it's not strictly necessary. This PR fixes the linked bug, so there's no reason it can't be merged.
Also, based on that query, it's possible that we meant to make Role names immutable but simply forgot to document it and make the TP changes. I'd want to `git blame` it and ask the person who modified the query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ericholguin commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
ericholguin commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1183265536
> Yes it's certainly possible, but it's not strictly necessary. This PR fixes the linked bug, so there's no reason it can't be merged.
I agree, it can be a separate PR.
>
> Also, based on that query, it's possible that we meant to make Role names immutable but simply forgot to document it and make the TP changes. I'd want to `git blame` it and ask the person who modified the query.
I think names have been mutable, per this legacy query that exists above the new one: https://github.com/apache/trafficcontrol/blob/235256986342c411c515554d871a2269b0169d5d/traffic_ops/traffic_ops_golang/role/roles.go#L61-L67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
ocket8888 merged PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] srijeet0406 commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
srijeet0406 commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1183371171
I _think_ the intention was to keep the role names immutable, but I'm totally on board with reversing that. As long as the `admin` role is immutable, which I believe it is, we should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ericholguin commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
ericholguin commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1182501294
> Yes and no. It's normal in that the endpoint as-is cannot change Role names. But that is itself a bug - but it's a bug with TO, and that's not the bug this PR claims to fix.
I see, so this fixes the TP issue. Is there an issue for TO. Looking at the code quickly the update query looks off
https://github.com/apache/trafficcontrol/blob/235256986342c411c515554d871a2269b0169d5d/traffic_ops/traffic_ops_golang/role/roles.go#L69-L74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1183331295
re-running CiaB action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ericholguin commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
ericholguin commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1182343298
I was able to update a role's description, but a role's name cannot be updated. Is this normal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ericholguin commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
ericholguin commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1183381072
> I _think_ the intention was to keep the role names immutable, but I'm totally on board with reversing that. As long as the `admin` role is immutable, which I believe it is, we should be fine.
Thanks for clearing that up @srijeet0406 . I believe in the issue that @rawlinp created he was trying to change the name of a user. So this is probably something we would want. I don't see any harm in having mutable role names, but I may be wrong. Also this change would match our docs, which currently don't say they are immutable. If no one is opposed I can create the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1182575583
is it possible to just fix both with this PR? TP and TO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1183334369
> I think names have been mutable, per this legacy query that exists above the new one
This makes me more sure the new behavior is intentional, otherwise the existing query language would've been re-used to a greater extent. I could still be wrong, but we'd need to hunt down the original proposal/PR to be sure. If that was the author's intent but was never communicated - or we just don't like that behavior -, we could reverse the decision even if it was intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #6955: TP Use Correct Name in Role Put
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #6955:
URL: https://github.com/apache/trafficcontrol/pull/6955#issuecomment-1182488867
> I was able to update a role's description, but a role's name cannot be updated, you will get the TP alert `role was updated.` displayed but the name remains the same. Is this normal?
Yes and no. It's normal in that the endpoint as-is cannot change Role names. But that is itself a bug - but it's a bug with TO, and that's not the bug this PR claims to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org