You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/01/30 19:46:55 UTC
[GitHub] spark pull request #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hiv...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20440
[SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHadoopFsRelationSuite
## What changes were proposed in this pull request?
Like Parquet, ORC test suites should enable UDT tests.
## How was this patch tested?
Pass the Jenkins with newly enabled test cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-23276
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20440
----
commit b8638293522ab143d624136337cf587ba49ca529
Author: Dongjoon Hyun <do...@...>
Date: 2018-01-30T19:45:31Z
[SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHadoopFsRelationSuite
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHa...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20440
Thank you for review, @HyukjinKwon .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20440
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hiv...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20440
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20440
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hiv...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20440#discussion_r164858264
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcHadoopFsRelationSuite.scala ---
@@ -34,11 +34,10 @@ class OrcHadoopFsRelationSuite extends HadoopFsRelationTest {
override val dataSourceName: String =
classOf[org.apache.spark.sql.execution.datasources.orc.OrcFileFormat].getCanonicalName
- // ORC does not play well with NullType and UDT.
+ // ORC does not play well with NullType.
override protected def supportsDataType(dataType: DataType): Boolean = dataType match {
case _: NullType => false
case _: CalendarIntervalType => false
- case _: UserDefinedType[_] => false
--- End diff --
Both `OrcHadoopFsRelationSuite` and `HiveOrcHadoopFsRelationSuite` enables UDT tests.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHa...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20440
Thank you, @HyukjinKwon and @gatorsmile !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20440
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/400/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHa...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20440
Thanks! Merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20440
**[Test build #86843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86843/testReport)** for PR 20440 at commit [`b863829`](https://github.com/apache/spark/commit/b8638293522ab143d624136337cf587ba49ca529).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20440
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86843/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20440: [SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20440
**[Test build #86843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86843/testReport)** for PR 20440 at commit [`b863829`](https://github.com/apache/spark/commit/b8638293522ab143d624136337cf587ba49ca529).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org