You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2020/06/23 12:23:32 UTC
[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling
Yida Wu has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/16083 )
Change subject: IMPALA-9829: Add Write Metrics for Spilling
......................................................................
IMPALA-9829: Add Write Metrics for Spilling
Three types of metrics are added in disk-io-mgr:
1. impala-server.io-mgr.queue-$0.write-latency, unit: ns,
kind: HistogramMetric
2. impala-server.io-mgr.queue-$0.write-size, unit: Bytes,
kind: HistogramMetric
3. impala-server.io-mgr.queue-$0.write-io-error, kind:IntCounter
Write size, latency and io errors will be recorded in
impala::io::DiskIoMgr::Write.
Testing:
* added DiskIoMgrTest.MetricsOfWriteSizeAndLatency
* added DiskIoMgrTest.MetricsOfWriteIoError
Ran unit test disk-io-mgr-test and pre-commit test
Change-Id: I152b9c5339cedabe33f8873a2bbf651aa5dbb914
---
M be/src/runtime/io/disk-io-mgr-internal.h
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/io/disk-io-mgr.cc
M be/src/runtime/io/disk-io-mgr.h
M common/thrift/metrics.json
5 files changed, 255 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/16083/6
--
To view, visit http://gerrit.cloudera.org:8080/16083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I152b9c5339cedabe33f8873a2bbf651aa5dbb914
Gerrit-Change-Number: 16083
Gerrit-PatchSet: 6
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>