You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/13 10:18:31 UTC

[GitHub] [apisix] tokers commented on a change in pull request #5158: feat: etcd cluster single node failure APISIX startup failure

tokers commented on a change in pull request #5158:
URL: https://github.com/apache/apisix/pull/5158#discussion_r727910452



##########
File path: apisix/cli/etcd.lua
##########
@@ -218,24 +219,22 @@ function _M.init(env, args)
 
             local cluster_version = body["etcdcluster"]
             if compare_semantic_version(cluster_version, env.min_etcd_version) then
-                util.die("etcd cluster version ", cluster_version,
-                        " is less than the required version ",
-                        env.min_etcd_version,
-                        ", please upgrade your etcd cluster\n")
+                util.die("etcd cluster version ", cluster_version, " is less than the required version ",
+                        env.min_etcd_version, ", please upgrade your etcd cluster\n")

Review comment:
       ```suggestion
                            env.min_etcd_version, ", please upgrade your etcd cluster\n")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org