You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/05/13 05:00:37 UTC
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #675: Fix various errors found by long running delta-streamer tests
vinothchandar commented on a change in pull request #675: Fix various errors found by long running delta-streamer tests
URL: https://github.com/apache/incubator-hudi/pull/675#discussion_r283187441
##########
File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieWriteClient.java
##########
@@ -1348,7 +1348,8 @@ private HoodieCommitMetadata doCompactionCommit(JavaRDD<WriteStatus> writeStatus
Optional<String> compactionInstantTimeOpt = scheduleCompaction(extraMetadata);
compactionInstantTimeOpt.ifPresent(compactionInstantTime -> {
try {
- compact(compactionInstantTime);
+ // inline compaction should auto commit as the user is never given control
Review comment:
good catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services