You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org> on 2008/03/11 01:55:28 UTC
[jira] Issue Comment Edited: (MNG-2744) checksum comparison should
be case-insensitive
[ http://jira.codehaus.org/browse/MNG-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126774 ]
bentmann edited comment on MNG-2744 at 3/10/08 7:54 PM:
-----------------------------------------------------------------
Brian, I don't want to question your endeavor to increase test coverage but I don't agree that this is a reason to prevent trivial fixes with tiny code changes from being applied as soon as possible. I would rather suggest to create sub tasks "Add test for XYZ" for those trivial patches where an accompanying test is nice to have but not necessary.
Anyway, here's my next try to patch the trunk, was really more than one line ;-) I's not elegant but shows the failure if unpatched.
was (Author: bentmann):
Brian, I don't want to question your endeavor to increase test coverage but I don't agree that this is a reason to prevent trivial fixes with tiny code changes from being applied as soon as possible. I would rather suggest to create sub tasks "Add test for XYZ" for those trivial patches where an accompanying is nice to have but not necessary.
Anyway, here's my next try to patch the trunk, was really more than one line ;-) I's not elegant but shows the failure if unpatched.
> checksum comparison should be case-insensitive
> ----------------------------------------------
>
> Key: MNG-2744
> URL: http://jira.codehaus.org/browse/MNG-2744
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.4
> Reporter: Ian Springer
> Fix For: 2.0.9
>
> Attachments: case-insensitive-checksums-2.0.x.patch, case-insensitive-checksums-2.1.x.patch, case-insensitive-checksums-2.1.x.patch
>
>
> Validation of MD5 and SHA1 checksums should be case-insensitive (since the individual characters represent hexadecimal digits). For example:
> [WARNING] *** CHECKSUM FAILED - Checksum failed on download: local = '9657ed010cea89caa1e35ae326dfccf28ea007f5'; remote
> = '9657ED010CEA89CAA1E35AE326DFCCF28EA007F5' - RETRYING
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira