You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/11/01 20:54:02 UTC

Review Request 63474: Added a regression test for MESOS-8135.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.


Bugs: MESOS-8135
    https://issues.apache.org/jira/browse/MESOS-8135


Repository: mesos


Description
-------

Added a regression test for MESOS-8135.


Diffs
-----

  src/tests/master_slave_reconciliation_tests.cpp d5eb7ba68c5308338236879e7cb1e970a01e48e6 


Diff: https://reviews.apache.org/r/63474/diff/1/


Testing
-------

Test passes on GNU/Linux.


Thanks,

Gaston Kleiman


Re: Review Request 63474: Added a regression test for MESOS-8135.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review189975
-----------------------------------------------------------


Fix it, then Ship it!




Would be great to have some better testing abstractions to clean up this test!


src/tests/master_slave_reconciliation_tests.cpp
Lines 718-720 (patched)
<https://reviews.apache.org/r/63474/#comment267217>

    Let's maybe adjust this to reflect that we're testing the API as well?



src/tests/master_slave_reconciliation_tests.cpp
Lines 852-854 (patched)
<https://reviews.apache.org/r/63474/#comment267221>

    In general, I think wrapping for less jaggedness is more readable:
    
    ```
          EXPECT_FALSE(task.has_executor_id())
            << "The command executor ID is present, but it"
            << " shouldn't be sent to the master";
    ```



src/tests/master_slave_reconciliation_tests.cpp
Lines 898 (patched)
<https://reviews.apache.org/r/63474/#comment267222>

    default



src/tests/master_slave_reconciliation_tests.cpp
Lines 899-901 (patched)
<https://reviews.apache.org/r/63474/#comment267224>

    The following looks a little more readable?
    
    ```
    EXPECT_EQ(defaultExecutorInfo.executor_id().value(),
              defaultExecutorTaskExecutorId);
    ```


- Benjamin Mahler


On Nov. 2, 2017, 7:51 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63474/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 7:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
>     https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a regression test for MESOS-8135.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp d5eb7ba68c5308338236879e7cb1e970a01e48e6 
> 
> 
> Diff: https://reviews.apache.org/r/63474/diff/2/
> 
> 
> Testing
> -------
> 
> Test passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 63474: Added a regression test for MESOS-8135.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review190007
-----------------------------------------------------------



Bad patch!

Reviews applied: [63474, 63353]

Failed command: python support/apply-reviews.py -n -r 63353

Error:
2017-11-03 05:03:18 URL:https://reviews.apache.org/r/63353/diff/raw/ [1009/1009] -> "63353.patch" [1]
error: patch failed: src/slave/slave.cpp:1537
error: src/slave/slave.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19978/console

- Mesos Reviewbot


On Nov. 2, 2017, 12:51 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63474/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 12:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
>     https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a regression test for MESOS-8135.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp d5eb7ba68c5308338236879e7cb1e970a01e48e6 
> 
> 
> Diff: https://reviews.apache.org/r/63474/diff/2/
> 
> 
> Testing
> -------
> 
> Test passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 63474: Added a regression test for MESOS-8135.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review190002
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 63353.

Failed command: `python.exe .\support\apply-reviews.py -n -r 63353`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63474

Relevant logs:

- [apply-review-63353-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63474/logs/apply-review-63353-stdout.log):

```
error: patch failed: src/slave/slave.cpp:1537
error: src/slave/slave.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 3, 2017, 3:51 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63474/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2017, 3:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
>     https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a regression test for MESOS-8135.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp d5eb7ba68c5308338236879e7cb1e970a01e48e6 
> 
> 
> Diff: https://reviews.apache.org/r/63474/diff/2/
> 
> 
> Testing
> -------
> 
> Test passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 63474: Added a regression test for MESOS-8135.

Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/
-----------------------------------------------------------

(Updated Nov. 2, 2017, 12:51 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.


Changes
-------

Check the master's `/state` endpoint response.


Bugs: MESOS-8135
    https://issues.apache.org/jira/browse/MESOS-8135


Repository: mesos


Description
-------

Added a regression test for MESOS-8135.


Diffs (updated)
-----

  src/tests/master_slave_reconciliation_tests.cpp d5eb7ba68c5308338236879e7cb1e970a01e48e6 


Diff: https://reviews.apache.org/r/63474/diff/2/

Changes: https://reviews.apache.org/r/63474/diff/1-2/


Testing
-------

Test passes on GNU/Linux.


Thanks,

Gaston Kleiman


Re: Review Request 63474: Added a regression test for MESOS-8135.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review189854
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63353, 63474]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 1, 2017, 8:54 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63474/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2017, 8:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
>     https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a regression test for MESOS-8135.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp d5eb7ba68c5308338236879e7cb1e970a01e48e6 
> 
> 
> Diff: https://reviews.apache.org/r/63474/diff/1/
> 
> 
> Testing
> -------
> 
> Test passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 63474: Added a regression test for MESOS-8135.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review189851
-----------------------------------------------------------



FAIL: Mesos tests failed to build.

Reviews applied: `['63353', '63474']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63474

Relevant logs:

- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63474/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\tests\sorter_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\tests\status_update_manager_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 'argument': conversion from 'double' to 'float', possible loss of data [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 'argument': truncation from 'double' to 'float' [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]


"C:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
(Link target) -> 
  default_executor_tests.obj : error LNK2001: unresolved external symbol "public: static char const * const mesos::internal::tests::KillPolicyTestHelper::NAME" (?NAME@KillPolicyTestHelper@tests@internal@mesos@@2QBDB) [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\src\mesos-tests.exe : fatal error LNK1120: 1 unresolved externals [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]

    454 Warning(s)
    2 Error(s)

Time Elapsed 01:11:04.58
```

- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63474/logs/mesos-tests-CMakeOutput.log):

```
  Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_b0e2c.dir\Debug\cmTC_b0e2c.tlog\".

InitializeBuildStatus:

  Creating "cmTC_b0e2c.dir\Debug\cmTC_b0e2c.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_b0e2c.dir\Debug\" /Fd"cmTC_b0e2c.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_b0e2c.dir\Debug\" /Fd"cmTC_b0e2c.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_b0e2c.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_b0e2c.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_b0e2c.lib" /MACHINE:X64  /machine:x64 cmTC_b0e2c.dir\Debug\src.obj

  cmTC_b0e2c.vcxproj -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_b0e2c.exe

  cmTC_b0e2c.vcxproj -> C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_b0e2c.pdb (Full PDB)

FinalizeBuildStatus:

  Deleting file "cmTC_b0e2c.dir\Debug\cmTC_b0e2c.tlog\unsuccessfulbuild".

  Touching "cmTC_b0e2c.dir\Debug\cmTC_b0e2c.tlog\cmTC_b0e2c.lastbuildstate".

Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_b0e2c.vcxproj" (default targets).



Build succeeded.

    0 Warning(s)

    0 Error(s)



Time Elapsed 00:00:01.85


Source file was:
int main() { return 0; }
```

- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63474/logs/mesos-tests-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_d81d0.dir\Debug\".

  Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_d81d0.dir\Debug\cmTC_d81d0.tlog\".

InitializeBuildStatus:

  Creating "cmTC_d81d0.dir\Debug\cmTC_d81d0.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_d81d0.dir\Debug\" /Fd"cmTC_d81d0.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_d81d0.dir\Debug\" /Fd"cmTC_d81d0.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

  

C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d81d0.vcxproj]

Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d81d0.vcxproj" (default targets) -- FAILED.



Build FAILED.



"C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d81d0.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d81d0.vcxproj]



    0 Warning(s)

    1 Error(s)



Time Elapsed 00:00:01.29



```

- Mesos Reviewbot Windows


On Nov. 1, 2017, 8:54 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63474/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2017, 8:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
>     https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a regression test for MESOS-8135.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp d5eb7ba68c5308338236879e7cb1e970a01e48e6 
> 
> 
> Diff: https://reviews.apache.org/r/63474/diff/1/
> 
> 
> Testing
> -------
> 
> Test passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>