You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/10/30 11:59:34 UTC
[GitHub] [systemds] j143 opened a new pull request #1427: [WIP] Promote svn repo directory dev/systemds/2.x-rc to release/systemds/2.x
j143 opened a new pull request #1427:
URL: https://github.com/apache/systemds/pull/1427
Not completely tested yet. But should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 merged pull request #1427: [SYSTEMDS-3193] Promote svn repo `dev/systemds/2.x-rc` to `release/systemds/2.x`
Posted by GitBox <gi...@apache.org>.
j143 merged pull request #1427:
URL: https://github.com/apache/systemds/pull/1427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on a change in pull request #1427: [SYSTEMDS-3193] Promote svn repo `dev/systemds/2.x-rc` to `release/systemds/2.x`
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on a change in pull request #1427:
URL: https://github.com/apache/systemds/pull/1427#discussion_r739671462
##########
File path: dev/release/release-to-svn.sh
##########
@@ -0,0 +1,82 @@
+#!/usr/bin/env bash
+#-------------------------------------------------------------
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+#-------------------------------------------------------------
+
+################################################################################
+## File: release-to-svn.sh
+## Desc: Promote release candidate from svn dev/systemds to release/systemds
Review comment:
I suggest changing the file name to `move_staging_to_release` or something along the line. The current name is not fully correct.
Add a point in the description that says to use this script only after successful voting of an RC.
##########
File path: dev/release/release-to-svn.sh
##########
@@ -0,0 +1,82 @@
+#!/usr/bin/env bash
+#-------------------------------------------------------------
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+#-------------------------------------------------------------
+
+################################################################################
+## File: release-to-svn.sh
+## Desc: Promote release candidate from svn dev/systemds to release/systemds
+################################################################################
+
+SELF=$(cd $(dirname $0) && pwd)
+
+dry_run_flag=0
+while getopts ":n" opt; do
+ case $opt in
+ n) dry_run_flag=1 ;;
+ \?) error "Invalid option: $OPTARG" ;;
+ esac
+done
+
+
+RELEASE_STAGING_LOCATION="https://dist.apache.org/repos/dist/dev/systemds"
+RELEASE_LOCATION="https://dist.apache.org/repos/dist/release/systemds"
+
+RELEASE_VERSION=
+APPROVED_RELEASE_TAG=
+
+read -p "RELEASE_VERSION : " RELEASE_VERSION
+read -p "APPROVED_RELEASE_TAG : " APPROVED_RELEASE_TAG
+
+tmp_repo=$(mktemp -d systemds-repo-tmp-XXXXX)
+
+pushd "${tmp_repo}"
+
+# 1. Checkout only the directory associated with approved release tag
+svn co --depth=empty $RELEASE_STAGING_LOCATION svn-dev-systemds
+cd svn-dev-systemds
+svn update --set-depth files ${APPROVED_RELEASE_TAG}
+cd ..
+
+# 2.1. Checkout the empty repo, and copy the contents from svn dev
+svn co --depth=empty $RELEASE_LOCATION svn-release-systemds
+mkdir -p svn-release-systemds/$RELEASE_VERSION
+
+cp svn-dev-systemds/${APPROVED_RELEASE_TAG}/systemds-* svn-release-systemds/$RELEASE_VERSION
+
+# 2.2. Add the files to svn
+svn add svn-release-systemds/$RELEASE_VERSION
+cd svn-release-systemds
+
+# 2.3. Commit and upload the files to the svn repository
+
+if [[ $dry_run_flag != 1 ]]; then
+ # This step prompts for the Apache Credentials
+ svn ci --username "$ASF_USERNAME" --password "$ASF_PASSWORD" -m"Apache SystemDS $RELEASE_VERSION Released" --no-auth-cache
+ echo $?
+else
+ printf "\n==========\n"
+ printf "This step would commit to the SVN release repo\n"
+ printf "At $RELEASE_LOCATION \n"
+ printf "\n==========\n"
+fi
Review comment:
It is a good idea to let the user verify the files before uploading.
You can mention the command `snv ci --` as a comment if dry_run is enabled so that after verifying the files locally one can just run that single command to upload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1427: [SYSTEMDS-3193] Promote svn repo `dev/systemds/2.x-rc` to `release/systemds/2.x`
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1427:
URL: https://github.com/apache/systemds/pull/1427#issuecomment-955378567
@phaniarnab - this seems to be ready! ✨
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on a change in pull request #1427: [WIP] Promote svn repo directory dev/systemds/2.x-rc to release/systemds/2.x
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on a change in pull request #1427:
URL: https://github.com/apache/systemds/pull/1427#discussion_r739645363
##########
File path: dev/release/release-to-svn.sh
##########
@@ -0,0 +1,46 @@
+#!/usr/bin/env bash
+#-------------------------------------------------------------
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+#-------------------------------------------------------------
+
+################################################################################
+## File: release-to-svn.sh
+## Desc: Promote release candidate from dev/systemds to release/systemds
+################################################################################
+
+SELF=$(cd $(dirname $0) && pwd)
+
+
+RELEASE_STAGING_LOCATION="https://dist.apache.org/repos/dist/dev/systemds"
+RELEASE_LOCATION="https://dist.apache.org/repos/dist/dev/systemds"
Review comment:
`RELEASE_LOCATION` seems to be wrong.
https://dist.apache.org/repos/dist/release/systemds/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org