You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2024/07/24 18:51:42 UTC
[Impala-ASF-CR] IMPALA-13166: Improve lookup of existing slot descriptors
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21531 )
Change subject: IMPALA-13166: Improve lookup of existing slot descriptors
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21531/1/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java
File fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java:
http://gerrit.cloudera.org:8080/#/c/21531/1/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java@84
PS1, Line 84: new HashMap<>()
Not sure what is the memory impact is by adding this field.
Is it worth to specify initialCapacity =1 ?
--
To view, visit http://gerrit.cloudera.org:8080/21531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id904ee8a641fb06ebca95b53ea29e78d120a2288
Gerrit-Change-Number: 21531
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2024 18:51:42 +0000
Gerrit-HasComments: Yes