You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2018/02/20 21:54:13 UTC
[GitHub] spark pull request #20644: [SPARK-23470][ui] Use first attempt of last stage...
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/20644
[SPARK-23470][ui] Use first attempt of last stage to define job description.
This is much faster than finding out what the last attempt is, and the
data should be the same.
There's room for improvement in this page (like only loading data for
the jobs being shown, instead of loading all available jobs and sorting
them), but this should bring performance on par with the 2.2 version.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vanzin/spark SPARK-23470
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20644.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20644
----
commit 0dc95ad83e9d736dedbb5d09d18513508847c0e4
Author: Marcelo Vanzin <va...@...>
Date: 2018-02-20T21:51:55Z
[SPARK-23470][ui] Use first attempt of last stage to define job description.
This is much faster than finding out what the last attempt is, and the
data should be the same.
There's room for improvement in this page (like only loading data for
the jobs being shown, instead of loading all available jobs and sorting
them), but this should bring performance on par with the 2.2 version.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20644
**[Test build #87568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87568/testReport)** for PR 20644 at commit [`0dc95ad`](https://github.com/apache/spark/commit/0dc95ad83e9d736dedbb5d09d18513508847c0e4).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20644
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20644
Thanks for fixing this so fast. I'm testing it now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by sameeragarwal <gi...@git.apache.org>.
Github user sameeragarwal commented on the issue:
https://github.com/apache/spark/pull/20644
merging this to master/2.3. Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20644
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87568/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20644
Verified that this patch fixes the issue. LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20644: [SPARK-23470][ui] Use first attempt of last stage...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20644
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20644
Tested by running:
```
(1 to 999).foreach { i =>
sc.parallelize(0 to i, i).count()
}
```
UI is not blazing fast, but usable.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20644
**[Test build #87568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87568/testReport)** for PR 20644 at commit [`0dc95ad`](https://github.com/apache/spark/commit/0dc95ad83e9d736dedbb5d09d18513508847c0e4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20644
@zsxwing
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20644
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/973/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20644
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org