You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/20 01:10:41 UTC

Review Request 43793: Increased the timeout in disk-heavy FilesystemIsolatorTests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43793/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Bugs: MESOS-4674
    https://issues.apache.org/jira/browse/MESOS-4674


Repository: mesos


Description
-------

Increases by 2x the amount of wait time in the `LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem` and `LinuxFilesystemIsolatorTest.ROOT_MultipleContainers` tests.


Diffs
-----

  src/tests/containerizer/filesystem_isolator_tests.cpp d8c3c81c3d5a4c4093b3d4b27bb5c123c77accfc 

Diff: https://reviews.apache.org/r/43793/diff/


Testing
-------

sudo make check on AWS instances of Centos7, Ubuntu 12, Ubuntu 14.

Timestamps on verbose logging suggest that the wait time may spike to 2 minutes in the `ImageInVolumeWithRootFilesystem` test.
I0219 23:38:39.982475 26760 copy.cpp:127]
I0219 23:40:38.113353 26757 linux.cpp:306]


Thanks,

Joseph Wu


Re: Review Request 43793: Increased the timeout in disk-heavy FilesystemIsolatorTests.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43793/#review119996
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 20, 2016, 12:10 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43793/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4674
>     https://issues.apache.org/jira/browse/MESOS-4674
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Increases by 2x the amount of wait time in the `LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem` and `LinuxFilesystemIsolatorTest.ROOT_MultipleContainers` tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp d8c3c81c3d5a4c4093b3d4b27bb5c123c77accfc 
> 
> Diff: https://reviews.apache.org/r/43793/diff/
> 
> 
> Testing
> -------
> 
> sudo make check on AWS instances of Centos7, Ubuntu 12, Ubuntu 14.
> 
> Timestamps on verbose logging suggest that the wait time may spike to 2 minutes in the `ImageInVolumeWithRootFilesystem` test.
> I0219 23:38:39.982475 26760 copy.cpp:127]
> I0219 23:40:38.113353 26757 linux.cpp:306]
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 43793: Increased the timeout in disk-heavy FilesystemIsolatorTests.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43793/#review120018
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43793]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 20, 2016, 12:10 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43793/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4674
>     https://issues.apache.org/jira/browse/MESOS-4674
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Increases by 2x the amount of wait time in the `LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem` and `LinuxFilesystemIsolatorTest.ROOT_MultipleContainers` tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp d8c3c81c3d5a4c4093b3d4b27bb5c123c77accfc 
> 
> Diff: https://reviews.apache.org/r/43793/diff/
> 
> 
> Testing
> -------
> 
> sudo make check on AWS instances of Centos7, Ubuntu 12, Ubuntu 14.
> 
> Timestamps on verbose logging suggest that the wait time may spike to 2 minutes in the `ImageInVolumeWithRootFilesystem` test.
> I0219 23:38:39.982475 26760 copy.cpp:127]
> I0219 23:40:38.113353 26757 linux.cpp:306]
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>