You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sangeeta Ravindran <sa...@gmail.com> on 2015/11/04 19:31:07 UTC
Review Request 39883: Alert notification create/edit/duplicate menu
items should be disabled for non-admin users
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39883/
-----------------------------------------------------------
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-13347
https://issues.apache.org/jira/browse/AMBARI-13347
Repository: ambari
Description
-------
If you log in as a non-admin operator user, and try to create an alert or edit/duplicate an existing alert and click on Save in the Manager Alert Notifications wizard, the UI seems to hang because the user is an operator and does not have the permission to access the resources related to alert management (underlying error HTTP 403).
The create/edit/alert options should be disabled for non-admin operator users since only admins have privileges to add/edit alert notifications.
Diffs
-----
ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs ed18c63
ambari-web/app/views/main/alerts/manage_alert_notifications_view.js c85d534
ambari-web/test/views/main/alerts/manage_alert_notifications_view_test.js a2822ce
Diff: https://reviews.apache.org/r/39883/diff/
Testing
-------
Did manual verification of the fix. Also updated test in manage_alert_notifications_view_test.js.
Ran "mvn clean test" for ambari-web project and build ran successfully.
10080 tests complete (16 seconds)
105 tests pending
Thanks,
Sangeeta Ravindran
Re: Review Request 39883: Alert notification create/edit/duplicate
menu items should be disabled for non-admin users
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39883/#review105758
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Nov. 4, 2015, 6:31 p.m., Sangeeta Ravindran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39883/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 6:31 p.m.)
>
>
> Review request for Ambari and Andrii Tkach.
>
>
> Bugs: AMBARI-13347
> https://issues.apache.org/jira/browse/AMBARI-13347
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If you log in as a non-admin operator user, and try to create an alert or edit/duplicate an existing alert and click on Save in the Manager Alert Notifications wizard, the UI seems to hang because the user is an operator and does not have the permission to access the resources related to alert management (underlying error HTTP 403).
> The create/edit/alert options should be disabled for non-admin operator users since only admins have privileges to add/edit alert notifications.
>
>
> Diffs
> -----
>
> ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs ed18c63
> ambari-web/app/views/main/alerts/manage_alert_notifications_view.js c85d534
> ambari-web/test/views/main/alerts/manage_alert_notifications_view_test.js a2822ce
>
> Diff: https://reviews.apache.org/r/39883/diff/
>
>
> Testing
> -------
>
> Did manual verification of the fix. Also updated test in manage_alert_notifications_view_test.js.
>
> Ran "mvn clean test" for ambari-web project and build ran successfully.
>
> 10080 tests complete (16 seconds)
> 105 tests pending
>
>
> Thanks,
>
> Sangeeta Ravindran
>
>