[GitHub] [cassandra] dcapwell commented on a change in pull request #729: CASSANDRA-15954: Include taskId in the compactionInfo toString

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #729:
URL: https://github.com/apache/cassandra/pull/729#discussion_r483785599



##########
File path: src/java/org/apache/cassandra/db/compaction/CompactionInfo.java
##########
@@ -132,6 +132,13 @@ public String toString()
         StringBuilder buff = new StringBuilder();
         buff.append(getTaskType());
 
+        if (getTaskId() != null)
+        {
+            buff.append('(')

Review comment:
       cleaner but to keep in-line with the other compaction logs 
   
   ````
   logger.info("Compacting ({}) {}", taskId, ssTableLoggerMsg);
   logger.info(String.format("Compacted (%s) %d sstables to [%s] to level=%d.  %s to %s (~%d%% of original) in %,dms.  Read Throughput = %s, Write Throughput = %s, Row Throughput = ~%,d/s.  %,d total partitions merged to %,d.  Partition merge counts were {%s}"
   ```
   
   it may be better to only update `org.apache.cassandra.db.compaction.CompactionInterruptedException` since this is what generates the message of `"Compaction interrupted: " + info`, so maybe this should really just be `"Compaction ("+info.getTaskId()+") interrupted: " + info`; this also lowers the changes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org