You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/12/07 11:52:05 UTC
[GitHub] [couchdb] rnewson opened a new pull request #3864: improve erlang_ls.config
rnewson opened a new pull request #3864:
URL: https://github.com/apache/couchdb/pull/3864
This fixes some of the include issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] rnewson commented on pull request #3864: improve erlang_ls.config
Posted by GitBox <gi...@apache.org>.
rnewson commented on pull request #3864:
URL: https://github.com/apache/couchdb/pull/3864#issuecomment-988640333
without this change it wasn't possibly for erlang_ls to see/index all the exported functions in other apps, etc. There might be other combinations of settings that work too but this worked for me so I stopped trying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva edited a comment on pull request #3864: improve erlang_ls.config
Posted by GitBox <gi...@apache.org>.
nickva edited a comment on pull request #3864:
URL: https://github.com/apache/couchdb/pull/3864#issuecomment-988333229
@kocolosk I think it's for "umbrella" apps, like what we have with our top level applications https://erlang-ls.github.io/configuration/#rebar3-umbrella-project
But I am not entirely sure what the difference is between deps and apps is, though. They seems to be doing largely the same thing.
With this setting go to definition, find references, "times used" and such seems to work within emacs across apps
<img width="550" alt="Screen Shot 2021-12-07 at 6 17 48 PM" src="https://user-images.githubusercontent.com/211822/145120867-ac540287-7cff-41fd-8c34-443f786f7f4b.png">
Also, I couldn't get the `Spec suggestions` lens to work. To remove the annoying prompts I can disable it with:
```
+lenses:
+ disabled:
+ - suggest-spec
```
Should we add it by default, or am I the only one seeing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] kocolosk commented on pull request #3864: improve erlang_ls.config
Posted by GitBox <gi...@apache.org>.
kocolosk commented on pull request #3864:
URL: https://github.com/apache/couchdb/pull/3864#issuecomment-988096987
What does the `apps_dirs` setting do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] rnewson merged pull request #3864: improve erlang_ls.config
Posted by GitBox <gi...@apache.org>.
rnewson merged pull request #3864:
URL: https://github.com/apache/couchdb/pull/3864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] kocolosk commented on pull request #3864: improve erlang_ls.config
Posted by GitBox <gi...@apache.org>.
kocolosk commented on pull request #3864:
URL: https://github.com/apache/couchdb/pull/3864#issuecomment-988406371
Yes, understood. I was being too terse, sorry. I was wanting to understand if that setting was fixing some "include issues". For some reason when I added this config file to the `main` branch in #3343 I did use the correct list of `include_dirs`, but I hadn't found a reason to set `apps_dirs`.
+1 to disabling `suggest-spec`. I was having problems with `typer` crashing, and I've seen some other reports of that happening as well. I also found it distracting.
I might also suggest disabling the `function-references` lens. The "Used N times" link is broken right now, and per erlang-ls/erlang_ls#991 they are thinking of removing it anyway. At least in VS Code the "Show Call Hierarchy" function provides that level of detail and more in a nicer presentation.
On the other hand, we many not want to be _too_ prescriptive about putting this config file in source control. Users can and will want to customize it themselves. Worth further discussion, but it might make sense to maintain a good sample config file in git but leave it to each individual developer to decide whether to copy it into place / modify it further.
But for now, +1 from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva edited a comment on pull request #3864: improve erlang_ls.config
Posted by GitBox <gi...@apache.org>.
nickva edited a comment on pull request #3864:
URL: https://github.com/apache/couchdb/pull/3864#issuecomment-988333229
@kocolosk I think it's for "umbrella" apps, like what we have with our top level applications https://erlang-ls.github.io/configuration/#rebar3-umbrella-project
But I am not entirely sure what the difference is between deps and apps is, though. They seems to be doing largely the same thing.
With this setting go to definition, find references, "times used" and such seems to work within emacs across apps
<img width="550" alt="Screen Shot 2021-12-07 at 6 17 48 PM" src="https://user-images.githubusercontent.com/211822/145120867-ac540287-7cff-41fd-8c34-443f786f7f4b.png">
Also, I couldn't get the `Spec suggestions` lens to work. To remove the annoying prompts I can disable it with:
```diff
+lenses:
+ disabled:
+ - suggest-spec
```
Should we add it by default, or am I the only one seeing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3864: improve erlang_ls.config
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3864:
URL: https://github.com/apache/couchdb/pull/3864#issuecomment-988333229
@kocolosk I think it's for "umbrella" apps, like what we have with our top level applications https://erlang-ls.github.io/configuration/#rebar3-umbrella-project
But I am not entirely sure what the difference is between deps and apps is, though. They seems to be doing largely the same thing.
With this setting go to definition, find references, "times used" and such seems to work within emacs across apps
<img width="550" alt="Screen Shot 2021-12-07 at 6 17 48 PM" src="https://user-images.githubusercontent.com/211822/145120867-ac540287-7cff-41fd-8c34-443f786f7f4b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org