[GitHub] [pulsar] Jason918 commented on a diff in pull request #15410: [improve][CLI] Support filtering system topic when get list.

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #15410:
URL: https://github.com/apache/pulsar/pull/15410#discussion_r862759643


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java:
##########
@@ -374,11 +374,19 @@ private class ListCmd extends CliCommand {
                 "--bundle" }, description = "Namespace bundle to get list of topics")
         private String bundle;
 
+        @Parameter(names = { "-wst",
+                "--with-system-topic" }, description = "Include system topic")

Review Comment:
   `--include-system-topic` is more descriptive?



##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java:
##########
@@ -52,7 +52,8 @@
 public interface Topics {
 
     enum QueryParam {
-        Bundle("bundle");
+        Bundle("bundle"),
+        WITH_SYSTEM_TOPIC("with_system_topic");

Review Comment:
   The naming style is not consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org