You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "countmdm (via GitHub)" <gi...@apache.org> on 2026/02/11 20:27:21 UTC

[PR] Update CHANGES.txt to reflect my optimization PR 15637 [lucene]

countmdm opened a new pull request, #15699:
URL: https://github.com/apache/lucene/pull/15699

   ### Description
   
   Update CHANGES.txt as requested by reviewers of my PR 15637.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Update CHANGES.txt to reflect my optimization PR 15637 [lucene]

Posted by "countmdm (via GitHub)" <gi...@apache.org>.
countmdm closed pull request #15699: Update CHANGES.txt to reflect my optimization PR 15637
URL: https://github.com/apache/lucene/pull/15699


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Update CHANGES.txt to reflect my optimization PR 15637 [lucene]

Posted by "countmdm (via GitHub)" <gi...@apache.org>.
countmdm commented on PR #15699:
URL: https://github.com/apache/lucene/pull/15699#issuecomment-3892950057

   > You should add a changes entry to the section/ version against which the patch is targeted, for example: https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L196
   > 
   > This is applied to branch_10x, then forward-ported to main (or applied to main and then backported to 10x) but it'll be consistent on both.
   
   Ok, I see. The CHANGES.txt file on the above link has a "Lucene 10.5.0" section. However, on my local main branch, this file only has "Lucene 11.0" and "Lucene 10.4.0" sections. 
   
   > You should add a changes entry to the section/ version against which the patch is targeted, for example: https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L196
   > 
   > This is applied to branch_10x, then forward-ported to main (or applied to main and then backported to 10x) but it'll be consistent on both.
   
   Oh, ok, sorry about myself being dumb, I forgot to update my Lucene fork :) Now I see that there is already a proper entry in CHANGES.txt for #15637 . So closing this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Update CHANGES.txt to reflect my optimization PR 15637 [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #15699:
URL: https://github.com/apache/lucene/pull/15699#issuecomment-3888968632

   You should add a changes entry to the section/ version against which the patch is targeted, for example:
   https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L196
   
   This is applied to branch_10x, then forward-ported to main (or applied to main and then backported to 10x) but it'll be consistent on both.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Update CHANGES.txt to reflect my optimization PR 15637 [lucene]

Posted by "countmdm (via GitHub)" <gi...@apache.org>.
countmdm commented on PR #15699:
URL: https://github.com/apache/lucene/pull/15699#issuecomment-3887676607

   > I think there is already a [CHANGES.txt ](https://github.com/apache/lucene/blob/448c7d8e2414eaae43b68cc398fcb3e2191b4132/lucene/CHANGES.txt#L196)entry (targeting 10.5) for #15637 . I think @dweiss added it for your PR?
   
   I am somewhat confused by how to keep track of all Lucene branches. But to the best of my knowledge, no, there is no entry for #15637. @dweiss once added an entry for my previous PR, #15618 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Update CHANGES.txt to reflect my optimization PR 15637 [lucene]

Posted by "shubhamsrkdev (via GitHub)" <gi...@apache.org>.
shubhamsrkdev commented on PR #15699:
URL: https://github.com/apache/lucene/pull/15699#issuecomment-3887653196

   I think there is already a [CHANGES.txt ](https://github.com/apache/lucene/blob/448c7d8e2414eaae43b68cc398fcb3e2191b4132/lucene/CHANGES.txt#L196)entry (targeting 10.5) for #15637 . I think @dweiss added it for your PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org