You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2014/09/23 18:10:13 UTC

[Bug 57010] New: [patch] Implement PROPER function

https://issues.apache.org/bugzilla/show_bug.cgi?id=57010

            Bug ID: 57010
           Summary: [patch] Implement PROPER function
           Product: POI
           Version: unspecified
          Hardware: PC
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HSSF
          Assignee: dev@poi.apache.org
          Reporter: patrick.zimmermann@haltec.de

Created attachment 32049
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32049&action=edit
proper.diff

Implement and test the PROPER function. I checked some Unicode letters too, but
I don't know if it behaves exactly as Excel in all Unicode (corner)cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 57010] [patch] Implement PROPER function

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57010

Patrick Zimmermann <pa...@haltec.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32049|0                           |1
        is obsolete|                            |

--- Comment #2 from Patrick Zimmermann <pa...@haltec.de> ---
Created attachment 32109
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32109&action=edit
proper_java6_comp.diff

Replaced Character class usage with a regular expression.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 57010] [patch] Implement PROPER function

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57010

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Dominik Stadler <do...@gmx.at> ---
Applied as r1633215, I had to adjust the regular expression as
"\P{IsAlphabetic}" is not available in Java 6, I used \P{IsL}, according to the
unit test this has the same effect.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 57010] [patch] Implement PROPER function

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57010

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
                 OS|                            |All

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 57010] [patch] Implement PROPER function

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57010

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Dominik Stadler <do...@gmx.at> ---
Unfortunately this does not apply cleanly, Character.isAlphabetic() was added
in Java 7, however we still want to be compatible with Java 6 as well, can you
redo the patch with this implemented slightly different so it still works with
Java 6 as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 57010] [patch] Implement PROPER function

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57010

Patrick Zimmermann <pa...@haltec.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #3 from Patrick Zimmermann <pa...@haltec.de> ---
(Hopefully) Java 6 compatible version is there.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org