You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Remy Maucherat <re...@apache.org> on 2002/12/19 12:15:19 UTC
[VOTE] Tomcat 4.1.18 release
A bug exists (unfortunately) in Tomcat 4.1.16 and Tomcat 4.1.17 which
causes the servlet Writer to stay in an invalid state after an
IOException occurs (99% of the time caused by an abrupt client
disconnection). After this happens, the processor will never be able to
output data using the Writer, causing blank pages. This is more often
seen with JSPs.
The bug affects Coyote HTTP/1.1, and may also affect Coyote JK 2,
although this is less likely.
It is proposed that Tomcat 4.1.18, based on the Tomcat 4.1.17 code, with
the addition of the patch committed by Bill fixing JK 2 SSL support, as
well as the following patch (which I committed one hour ago):
Index: CoyoteResponse.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v
retrieving revision 1.30
diff -r1.30 CoyoteResponse.java
322a323,324
> writer.recycle();
>
Index: CoyoteWriter.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteWriter.java,v
retrieving revision 1.2
diff -r1.2 CoyoteWriter.java
98a99,109
> // --------------------------------------------------------
Package Methods
>
>
> /**
> * Recycle.
> */
> void recycle() {
> error = false;
> }
>
>
Please review, and vote ASAP:
<ballot>
[ ] Yes
[ ] No
</ballot>
Remy
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.1.18 release
Posted by "Jess M. Holle" <je...@ptc.com>.
I'm not a commiter (so no real vote), but I was just on the verge of
patching in these very fixes into 4.1.17 as it is useless to me without
them.
I would *REALLY* appreciate a speedy 4.1.18 release.
--
Jess Holle
Remy Maucherat wrote:
> A bug exists (unfortunately) in Tomcat 4.1.16 and Tomcat 4.1.17 which
> causes the servlet Writer to stay in an invalid state after an
> IOException occurs (99% of the time caused by an abrupt client
> disconnection). After this happens, the processor will never be able
> to output data using the Writer, causing blank pages. This is more
> often seen with JSPs.
>
> The bug affects Coyote HTTP/1.1, and may also affect Coyote JK 2,
> although this is less likely.
>
> It is proposed that Tomcat 4.1.18, based on the Tomcat 4.1.17 code,
> with the addition of the patch committed by Bill fixing JK 2 SSL
> support, as well as the following patch (which I committed one hour ago):
>
> Index: CoyoteResponse.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v
>
> retrieving revision 1.30
> diff -r1.30 CoyoteResponse.java
> 322a323,324
> > writer.recycle();
> >
> Index: CoyoteWriter.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteWriter.java,v
>
> retrieving revision 1.2
> diff -r1.2 CoyoteWriter.java
> 98a99,109
> > // --------------------------------------------------------
> Package Methods
> >
> >
> > /**
> > * Recycle.
> > */
> > void recycle() {
> > error = false;
> > }
> >
> >
>
> Please review, and vote ASAP:
>
> <ballot>
> [ ] Yes
> [ ] No
> </ballot>
>
> Remy
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.1.18 release
Posted by Torsten Fohrer <TF...@t-online.de>.
As a user that have this problem too.....
[YES]
On Thursday 19 December 2002 12:15, you wrote:
> A bug exists (unfortunately) in Tomcat 4.1.16 and Tomcat 4.1.17 which
> causes the servlet Writer to stay in an invalid state after an
> IOException occurs (99% of the time caused by an abrupt client
> disconnection). After this happens, the processor will never be able to
> output data using the Writer, causing blank pages. This is more often
> seen with JSPs.
>
> The bug affects Coyote HTTP/1.1, and may also affect Coyote JK 2,
> although this is less likely.
>
> It is proposed that Tomcat 4.1.18, based on the Tomcat 4.1.17 code, with
> the addition of the patch committed by Bill fixing JK 2 SSL support, as
> well as the following patch (which I committed one hour ago):
>
> Index: CoyoteResponse.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomca
>t4/CoyoteResponse.java,v retrieving revision 1.30
> diff -r1.30 CoyoteResponse.java
> 322a323,324
>
> > writer.recycle();
>
> Index: CoyoteWriter.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomca
>t4/CoyoteWriter.java,v retrieving revision 1.2
> diff -r1.2 CoyoteWriter.java
> 98a99,109
>
> > // --------------------------------------------------------
>
> Package Methods
>
> > /**
> > * Recycle.
> > */
> > void recycle() {
> > error = false;
> > }
>
> Please review, and vote ASAP:
>
> <ballot>
> [ ] Yes
> [ ] No
> </ballot>
>
> Remy
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org> For additional commands,
> e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.1.18 release
Posted by Amy Roh <am...@apache.org>.
> Please review, and vote ASAP:
>
> <ballot>
> [X] Yes
> [ ] No
> </ballot>
>
Amy
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.1.18 release
Posted by Bill Barker <wb...@wilshire.com>.
> Please review, and vote ASAP:
>
> <ballot>
> [X] Yes
> [ ] No
> </ballot>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.1.18 release
Posted by Henri Gomez <hg...@apache.org>.
+1
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.1.18 release
Posted by Mark Plotnick <pl...@ensodex.com>.
** Reply to message from Remy Maucherat <re...@apache.org> on Thu, 19 Dec 2002
12:15:19 +0100
>
> It is proposed that Tomcat 4.1.18, based on the Tomcat 4.1.17 code, with
> ............
> Please review, and vote ASAP:
>
> <ballot>
> [ ] Yes
> [ ] No
> </ballot>
[X] Yes
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.1.18 release
Posted by Costin Manolache <cm...@yahoo.com>.
I think we don't have too many choices here - it's something we must
do.
+1
Costin
Remy Maucherat wrote:
> A bug exists (unfortunately) in Tomcat 4.1.16 and Tomcat 4.1.17 which
> causes the servlet Writer to stay in an invalid state after an
> IOException occurs (99% of the time caused by an abrupt client
> disconnection). After this happens, the processor will never be able to
> output data using the Writer, causing blank pages. This is more often
> seen with JSPs.
>
> The bug affects Coyote HTTP/1.1, and may also affect Coyote JK 2,
> although this is less likely.
>
> It is proposed that Tomcat 4.1.18, based on the Tomcat 4.1.17 code, with
> the addition of the patch committed by Bill fixing JK 2 SSL support, as
> well as the following patch (which I committed one hour ago):
>
> Index: CoyoteResponse.java
> ===================================================================
> RCS file:
>
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v
> retrieving revision 1.30
> diff -r1.30 CoyoteResponse.java
> 322a323,324
> > writer.recycle();
> >
> Index: CoyoteWriter.java
> ===================================================================
> RCS file:
>
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteWriter.java,v
> retrieving revision 1.2
> diff -r1.2 CoyoteWriter.java
> 98a99,109
> > // --------------------------------------------------------
> Package Methods
> >
> >
> > /**
> > * Recycle.
> > */
> > void recycle() {
> > error = false;
> > }
> >
> >
>
> Please review, and vote ASAP:
>
> <ballot>
> [ ] Yes
> [ ] No
> </ballot>
>
> Remy
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.1.18 release
Posted by Jeanfrancois Arcand <jf...@apache.org>.
+1
-- Jeanfrancois
Remy Maucherat wrote:
> A bug exists (unfortunately) in Tomcat 4.1.16 and Tomcat 4.1.17 which
> causes the servlet Writer to stay in an invalid state after an
> IOException occurs (99% of the time caused by an abrupt client
> disconnection). After this happens, the processor will never be able
> to output data using the Writer, causing blank pages. This is more
> often seen with JSPs.
>
> The bug affects Coyote HTTP/1.1, and may also affect Coyote JK 2,
> although this is less likely.
>
> It is proposed that Tomcat 4.1.18, based on the Tomcat 4.1.17 code,
> with the addition of the patch committed by Bill fixing JK 2 SSL
> support, as well as the following patch (which I committed one hour ago):
>
> Index: CoyoteResponse.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v
>
> retrieving revision 1.30
> diff -r1.30 CoyoteResponse.java
> 322a323,324
> > writer.recycle();
> >
> Index: CoyoteWriter.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteWriter.java,v
>
> retrieving revision 1.2
> diff -r1.2 CoyoteWriter.java
> 98a99,109
> > // --------------------------------------------------------
> Package Methods
> >
> >
> > /**
> > * Recycle.
> > */
> > void recycle() {
> > error = false;
> > }
> >
> >
>
> Please review, and vote ASAP:
>
> <ballot>
> [ ] Yes
> [ ] No
> </ballot>
>
> Remy
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.1.18 release
Posted by Punky Tse <pu...@punknix.com>.
Remy,
I checked the cvs and found there are some number of changes in the
writer and response in coyote starting from 4.1.12. (See the diff from
4.1.12). Many of the changes are started at around 4.1.15/16.
I think there is the problem in the roll out procedures, especially when
a release is voted by the committer as stable and before the release
manager declare it as GA. Stability test and code review should be
thoroughly run.
May be in 5.0, we could do better on this.
- Punky
P.S. I remember there was discussion in the release procedure or
numbering guides. But I cannot find one in tomcat site. Is it just
from http project? (http://httpd.apache.org/dev/release.html)
Remy Maucherat wrote:
> A bug exists (unfortunately) in Tomcat 4.1.16 and Tomcat 4.1.17 which
> causes the servlet Writer to stay in an invalid state after an
> IOException occurs (99% of the time caused by an abrupt client
> disconnection). After this happens, the processor will never be able to
> output data using the Writer, causing blank pages. This is more often
> seen with JSPs.
>
> The bug affects Coyote HTTP/1.1, and may also affect Coyote JK 2,
> although this is less likely.
>
> It is proposed that Tomcat 4.1.18, based on the Tomcat 4.1.17 code, with
> the addition of the patch committed by Bill fixing JK 2 SSL support, as
> well as the following patch (which I committed one hour ago):
>
> Index: CoyoteResponse.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v
>
> retrieving revision 1.30
> diff -r1.30 CoyoteResponse.java
> 322a323,324
> > writer.recycle();
> >
> Index: CoyoteWriter.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteWriter.java,v
>
> retrieving revision 1.2
> diff -r1.2 CoyoteWriter.java
> 98a99,109
> > // --------------------------------------------------------
> Package Methods
> >
> >
> > /**
> > * Recycle.
> > */
> > void recycle() {
> > error = false;
> > }
> >
> >
>
> Please review, and vote ASAP:
>
> <ballot>
> [ ] Yes
> [ ] No
> </ballot>
>
> Remy
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
Re: [VOTE] Tomcat 4.1.18 release
Posted by Matt Fury <ma...@yahoo.com>.
Please review, and vote ASAP:
<ballot>
[x] Yes
[ ] No
</ballot>
-Matt
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>