[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5167: Fix selection early termination test

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5167: Fix selection early termination test
URL: https://github.com/apache/incubator-pinot/pull/5167#discussion_r395381772
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/operator/CombineOperator.java
 ##########
 @@ -126,8 +126,12 @@ public void runJob() {
         }
       });
     }
+    // TODO: we can track a volatile variable "desiredLimitReached"
 
 Review comment:
   We will cancel the future in line 187. Here we should catch the InterruptedException and silently return, or we might end up logging lots of invalid ERROR messages.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org