You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "hemantk-12 (via GitHub)" <gi...@apache.org> on 2024/04/17 22:32:03 UTC
[PR] HDDS-9039. Removed the pause and wait in RocksDB compaction when tarball creation is in progress [ozone]
hemantk-12 opened a new pull request, #6552:
URL: https://github.com/apache/ozone/pull/6552
## What changes were proposed in this pull request?
As part of the change https://github.com/apache/ozone/pull/4680#issuecomment-1553512855, it was asked to add sequence number to compaction logs (HDDS-8652) and later pause in the RocksDB compaction when tarball creation is in progress (HDDS-9004 and HDDS-9064). These changes were valid when a text file was used to store compaction log entries.
After HDDS-9311, compaction logs were migrated to the RocksDB column family. Now we can simply rely on RocksDB's synchronization. Either the compaction entry will be present in the compactionLog columnFamily or not in the snapshot of the ActiveFS depending on the order of compaction entry append and checkpoint creation.
This change is to remove the wait and notify logic between RocksDB's compaction and tarball creation.
## What is the link to the Apache JIRA
HDDS-9039
## How was this patch tested?
Updated existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9039. Removed the pause and wait in RocksDB compaction when tarball creation is in progress [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 merged PR #6552:
URL: https://github.com/apache/ozone/pull/6552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9039. Removed the pause and wait in RocksDB compaction when tarball creation is in progress [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on PR #6552:
URL: https://github.com/apache/ozone/pull/6552#issuecomment-2108875402
Thanks @swamirishi for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org