You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/01 21:53:27 UTC
Review Request 68154: Fixed gRPC compilation for standalone
libprocess build with Clang.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68154/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-8395
https://issues.apache.org/jira/browse/MESOS-8395
Repository: mesos
Description
-------
When compiling gRPC with Clang, there are some array-out-of-bound
warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
library. With `-Werror` on, these warnings would stop gRPC from
compiling. This patch ignores such errors.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am da350b1d36b9f545372999f38acc5022a9ca1034
Diff: https://reviews.apache.org/r/68154/diff/1/
Testing
-------
`make check` for libprocess
Thanks,
Chun-Hung Hsiao
Re: Review Request 68154: Fixed gRPC compilation for standalone
libprocess build with Clang.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68154/#review206787
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Aug. 1, 2018, 11:53 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68154/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 11:53 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-8395
> https://issues.apache.org/jira/browse/MESOS-8395
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When compiling gRPC with Clang, there are some array-out-of-bound
> warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
> library. With `-Werror` on, these warnings would stop gRPC from
> compiling. This patch ignores such errors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am da350b1d36b9f545372999f38acc5022a9ca1034
>
>
> Diff: https://reviews.apache.org/r/68154/diff/1/
>
>
> Testing
> -------
>
> `make check` for libprocess
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>