You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/14 08:09:53 UTC
[GitHub] yucai commented on a change in pull request #23510:
[SPARK-26590][CORE] make fetch-block-to-disk backward compatible
yucai commented on a change in pull request #23510: [SPARK-26590][CORE] make fetch-block-to-disk backward compatible
URL: https://github.com/apache/spark/pull/23510#discussion_r247405612
##########
File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
##########
@@ -81,6 +77,17 @@ public void removeFetchRequest(StreamChunkId streamChunkId) {
outstandingFetches.remove(streamChunkId);
}
+ public void addFetchAsStreamRequest(
+ StreamChunkId streamChunkId,
+ StreamCallback callback) {
+ updateTimeOfLastRequest();
Review comment:
indent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org