You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/12/10 02:33:40 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #5055: [enhancement]improve performance of json load
yangzhg opened a new pull request #5055:
URL: https://github.com/apache/incubator-doris/pull/5055
## Proposed changes
There are two points that affect performance in the current json load:
1 json is actually a traversal operation for searching by key. We call HasMember and operator[] twice, and need to traverse twice
2 If you use a string as the key to find the json object, strlen will be called every time, so the number of calls to strlen is the row number * column number
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [] I have create an issue on (Fix #5054), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #5055: [enhancement]improve performance of json load
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #5055:
URL: https://github.com/apache/incubator-doris/pull/5055#discussion_r539902865
##########
File path: be/src/exec/json_scanner.cpp
##########
@@ -273,9 +269,11 @@ void JsonReader::_close() {
// return Status::OK() if parse succeed or reach EOF.
Status JsonReader::_parse_json_doc(bool* eof) {
// read a whole message, must be delete json_str by `delete[]`
+ SCOPED_TIMER(_read_timer);
Review comment:
Add a new timer name 'parse json timer' to track the parse json time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #5055: [enhancement]improve performance of json load
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #5055:
URL: https://github.com/apache/incubator-doris/pull/5055#discussion_r539902322
##########
File path: be/src/exec/json_scanner.cpp
##########
@@ -54,7 +54,6 @@ Status JsonScanner::open() {
}
Status JsonScanner::get_next(Tuple* tuple, MemPool* tuple_pool, bool* eof) {
- SCOPED_TIMER(_read_timer);
Review comment:
why delete this read_timer? Maybe should keep the same with orc scanner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #5055: [enhancement]improve performance of json load
Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #5055:
URL: https://github.com/apache/incubator-doris/pull/5055
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #5055: [enhancement]improve performance of json load
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #5055:
URL: https://github.com/apache/incubator-doris/pull/5055#discussion_r539880337
##########
File path: be/src/exec/json_scanner.cpp
##########
@@ -54,7 +54,6 @@ Status JsonScanner::open() {
}
Status JsonScanner::get_next(Tuple* tuple, MemPool* tuple_pool, bool* eof) {
- SCOPED_TIMER(_read_timer);
// Get one line
Review comment:
Why delete the reader timer？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org