You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/06/02 23:53:02 UTC
[jira] [Commented] (STORM-244) DRPC timeout can return null instead
of throwing an exception
[ https://issues.apache.org/jira/browse/STORM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015944#comment-14015944 ]
ASF GitHub Bot commented on STORM-244:
--------------------------------------
GitHub user knusbaum opened a pull request:
https://github.com/apache/incubator-storm/pull/132
Fix for STORM-244
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-244
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #132
----
commit 4c61cd40023ae31cb9045e04360b376736969d3d
Author: Kyle Nusbaum <kn...@yahoo-inc.com>
Date: 2014-06-02T20:56:37Z
Fix for STORM-244
----
> DRPC timeout can return null instead of throwing an exception
> -------------------------------------------------------------
>
> Key: STORM-244
> URL: https://issues.apache.org/jira/browse/STORM-244
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Robert Joseph Evans
>
> In DPRC there is a race condition when the cleanup method is called between releasing the sem, cleaning up the atoms and the blocked thread fetching the result. It looks like it is possible on a timeout that the sem will be released but by the time the thread blocked on the sem actually wakes up the result may have been removed, causing a null to be returned instead of an exception being thrown.
--
This message was sent by Atlassian JIRA
(v6.2#6252)