You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2011/03/08 07:58:59 UTC
[jira] Created: (ARIES-599) Consistently use SLF4J Logging
Consistently use SLF4J Logging
------------------------------
Key: ARIES-599
URL: https://issues.apache.org/jira/browse/ARIES-599
Project: Aries
Issue Type: Bug
Reporter: Felix Meschberger
It looks like certain classes are not using SLF4J API as should be done according to Alasdair Nottingham [1].
One such example is the JNDI Core BundleActivator [2]. Will search for others and try to provide a patch.
[1] http://markmail.org/message/hzwtvpqijt6tdnia
[2] http://svn.apache.org/repos/asf/aries/trunk/jndi/jndi-core/src/main/java/org/apache/aries/jndi/startup/Activator.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ARIES-599) Consistently use SLF4J Logging
Posted by "Jeremy Hughes (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hughes updated ARIES-599:
--------------------------------
Fix Version/s: jndi uber bundle 0.3.1
jndi.rmi-0.3.1
jndi.url-0.3.1
jndi.core-0.3.1
> Consistently use SLF4J Logging
> ------------------------------
>
> Key: ARIES-599
> URL: https://issues.apache.org/jira/browse/ARIES-599
> Project: Aries
> Issue Type: Bug
> Components: JNDI
> Affects Versions: 0.3
> Reporter: Felix Meschberger
> Assignee: Alasdair Nottingham
> Fix For: jndi.core-0.3.1, jndi.url-0.3.1, jndi.rmi-0.3.1, jndi uber bundle 0.3.1
>
> Attachments: ARIES-599-2.patch, ARIES-599.patch
>
>
> It looks like certain classes are not using SLF4J API as should be done according to Alasdair Nottingham [1].
> One such example is the JNDI Core BundleActivator [2]. Will search for others and try to provide a patch.
> [1] http://markmail.org/message/hzwtvpqijt6tdnia
> [2] http://svn.apache.org/repos/asf/aries/trunk/jndi/jndi-core/src/main/java/org/apache/aries/jndi/startup/Activator.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ARIES-599) Consistently use SLF4J Logging
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated ARIES-599:
------------------------------------
Attachment: ARIES-599.patch
Turns out its only two files actually: The Bundle activators of the JNDI Core and JNDI RMI bundles.
Attached patch replaces Java Util Logging with SLF4J in these bundles
> Consistently use SLF4J Logging
> ------------------------------
>
> Key: ARIES-599
> URL: https://issues.apache.org/jira/browse/ARIES-599
> Project: Aries
> Issue Type: Bug
> Reporter: Felix Meschberger
> Attachments: ARIES-599.patch
>
>
> It looks like certain classes are not using SLF4J API as should be done according to Alasdair Nottingham [1].
> One such example is the JNDI Core BundleActivator [2]. Will search for others and try to provide a patch.
> [1] http://markmail.org/message/hzwtvpqijt6tdnia
> [2] http://svn.apache.org/repos/asf/aries/trunk/jndi/jndi-core/src/main/java/org/apache/aries/jndi/startup/Activator.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ARIES-599) Consistently use SLF4J Logging
Posted by "Alasdair Nottingham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004644#comment-13004644 ]
Alasdair Nottingham commented on ARIES-599:
-------------------------------------------
The latest patch fixes the core tests, but the url tests still fail. When I commit I'll include a fix to that.
> Consistently use SLF4J Logging
> ------------------------------
>
> Key: ARIES-599
> URL: https://issues.apache.org/jira/browse/ARIES-599
> Project: Aries
> Issue Type: Bug
> Components: JNDI
> Affects Versions: 0.3
> Reporter: Felix Meschberger
> Attachments: ARIES-599-2.patch, ARIES-599.patch
>
>
> It looks like certain classes are not using SLF4J API as should be done according to Alasdair Nottingham [1].
> One such example is the JNDI Core BundleActivator [2]. Will search for others and try to provide a patch.
> [1] http://markmail.org/message/hzwtvpqijt6tdnia
> [2] http://svn.apache.org/repos/asf/aries/trunk/jndi/jndi-core/src/main/java/org/apache/aries/jndi/startup/Activator.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ARIES-599) Consistently use SLF4J Logging
Posted by "Alasdair Nottingham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003920#comment-13003920 ]
Alasdair Nottingham commented on ARIES-599:
-------------------------------------------
Applying the provided patch causes the tests to fail with the following exception:
java.lang.NoClassDefFoundError: org/slf4j/impl/StaticLoggerBinder
at org.slf4j.LoggerFactory.getSingleton(LoggerFactory.java:230)
at org.slf4j.LoggerFactory.bind(LoggerFactory.java:121)
at org.slf4j.LoggerFactory.performInitialization(LoggerFactory.java:112)
at org.slf4j.LoggerFactory.getILoggerFactory(LoggerFactory.java:275)
at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:248)
at org.apache.aries.jndi.startup.Activator.<clinit>(Activator.java:56)
at org.apache.aries.jndi.InitialContextTest.setup(InitialContextTest.java:71)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
I suspect this is because we have the slf4j api, but not the impl in the pom.
> Consistently use SLF4J Logging
> ------------------------------
>
> Key: ARIES-599
> URL: https://issues.apache.org/jira/browse/ARIES-599
> Project: Aries
> Issue Type: Bug
> Reporter: Felix Meschberger
> Attachments: ARIES-599.patch
>
>
> It looks like certain classes are not using SLF4J API as should be done according to Alasdair Nottingham [1].
> One such example is the JNDI Core BundleActivator [2]. Will search for others and try to provide a patch.
> [1] http://markmail.org/message/hzwtvpqijt6tdnia
> [2] http://svn.apache.org/repos/asf/aries/trunk/jndi/jndi-core/src/main/java/org/apache/aries/jndi/startup/Activator.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (ARIES-599) Consistently use SLF4J Logging
Posted by "Alasdair Nottingham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alasdair Nottingham resolved ARIES-599.
---------------------------------------
Resolution: Fixed
Assignee: Alasdair Nottingham
> Consistently use SLF4J Logging
> ------------------------------
>
> Key: ARIES-599
> URL: https://issues.apache.org/jira/browse/ARIES-599
> Project: Aries
> Issue Type: Bug
> Components: JNDI
> Affects Versions: 0.3
> Reporter: Felix Meschberger
> Assignee: Alasdair Nottingham
> Attachments: ARIES-599-2.patch, ARIES-599.patch
>
>
> It looks like certain classes are not using SLF4J API as should be done according to Alasdair Nottingham [1].
> One such example is the JNDI Core BundleActivator [2]. Will search for others and try to provide a patch.
> [1] http://markmail.org/message/hzwtvpqijt6tdnia
> [2] http://svn.apache.org/repos/asf/aries/trunk/jndi/jndi-core/src/main/java/org/apache/aries/jndi/startup/Activator.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ARIES-599) Consistently use SLF4J Logging
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated ARIES-599:
------------------------------------
Component/s: JNDI
Affects Version/s: 0.3
> Consistently use SLF4J Logging
> ------------------------------
>
> Key: ARIES-599
> URL: https://issues.apache.org/jira/browse/ARIES-599
> Project: Aries
> Issue Type: Bug
> Components: JNDI
> Affects Versions: 0.3
> Reporter: Felix Meschberger
> Attachments: ARIES-599-2.patch, ARIES-599.patch
>
>
> It looks like certain classes are not using SLF4J API as should be done according to Alasdair Nottingham [1].
> One such example is the JNDI Core BundleActivator [2]. Will search for others and try to provide a patch.
> [1] http://markmail.org/message/hzwtvpqijt6tdnia
> [2] http://svn.apache.org/repos/asf/aries/trunk/jndi/jndi-core/src/main/java/org/apache/aries/jndi/startup/Activator.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ARIES-599) Consistently use SLF4J Logging
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated ARIES-599:
------------------------------------
Attachment: ARIES-599-2.patch
Oops, sorry. Correct. Attached is a patch adding the slf4j-simple dependency for the tests
> Consistently use SLF4J Logging
> ------------------------------
>
> Key: ARIES-599
> URL: https://issues.apache.org/jira/browse/ARIES-599
> Project: Aries
> Issue Type: Bug
> Components: JNDI
> Affects Versions: 0.3
> Reporter: Felix Meschberger
> Attachments: ARIES-599-2.patch, ARIES-599.patch
>
>
> It looks like certain classes are not using SLF4J API as should be done according to Alasdair Nottingham [1].
> One such example is the JNDI Core BundleActivator [2]. Will search for others and try to provide a patch.
> [1] http://markmail.org/message/hzwtvpqijt6tdnia
> [2] http://svn.apache.org/repos/asf/aries/trunk/jndi/jndi-core/src/main/java/org/apache/aries/jndi/startup/Activator.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira