You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/04 16:08:16 UTC

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat commented on a change in pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#discussion_r465163841



##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -71,11 +75,40 @@ public HostInfo getActiveHost() {
      * Get the Store partition corresponding to the key.
      *
      * @return store partition number
+     * @deprecated Use {@link #partition()} instead.
      */
+    @Deprecated
     public int getPartition() {
         return partition;
     }
 
+    /**
+     * Get the Active streams instance for given key

Review comment:
       I'm with you, we should fix it, for the deprecated ones too.
   
   Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org