You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/08/23 13:09:06 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #36967: GH-36924: [Java] support offset/length and filter in scan option

pitrou commented on code in PR #36967:
URL: https://github.com/apache/arrow/pull/36967#discussion_r1302994295


##########
cpp/src/arrow/dataset/scanner.h:
##########
@@ -55,6 +55,7 @@ constexpr int64_t kDefaultBatchSize = 1 << 17;  // 128Ki rows
 constexpr int32_t kDefaultBatchReadahead = 16;
 constexpr int32_t kDefaultFragmentReadahead = 4;
 constexpr int32_t kDefaultBytesReadahead = 1 << 25;  // 32MiB
+constexpr int64_t kDefaultStartOffset = -1;

Review Comment:
   Well, why not simply 0? Isn't starting from 0 the default behavior?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org