You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/09/19 09:14:30 UTC
[GitHub] [netbeans] mbien opened a new pull request #3176: [jackpot] source version fix for java versions using the new scheme.
mbien opened a new pull request #3176:
URL: https://github.com/apache/netbeans/pull/3176
:: sourceVersionGE(...) only worked with the old scheme. Trivial fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3176: [jackpot] source version fix for java versions using the new scheme.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3176:
URL: https://github.com/apache/netbeans/pull/3176#issuecomment-922496413
failure of `org.netbeans.modules.ide.kit.VerifySimpleTemplatesTest` is not reproducible for me
```
java -version
openjdk version "1.8.0_302"
OpenJDK Runtime Environment Corretto-8.302.08.1 (build 1.8.0_302-b08)
OpenJDK 64-Bit Server VM Corretto-8.302.08.1 (build 25.302-b08, mixed mode)
ant test
Buildfile: /home/mbien/NetBeansProjects/netbeans/java/java.lsp.server/nbcode/integration/build.xml
...
...
BUILD SUCCESSFUL
Total time: 1 minute 26 seconds
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda merged pull request #3176: [jackpot] source version fix for java versions using the new scheme.
Posted by GitBox <gi...@apache.org>.
jlahoda merged pull request #3176:
URL: https://github.com/apache/netbeans/pull/3176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3176: [jackpot] source version fix for java versions using the new scheme.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3176:
URL: https://github.com/apache/netbeans/pull/3176#issuecomment-932299416
> Looks reasonable. We could also consider using `CompilationInfo.getSourceVersion()`.
you are right, this is much better. Changed it to a one-liner and did some manual testing, seems to work fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3176: [jackpot] source version fix for java versions using the new scheme.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3176:
URL: https://github.com/apache/netbeans/pull/3176#issuecomment-931642538
@jlahoda would you like to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists