[jira] [Commented] (ORC-193) Refactor WriterImp to move TreeWriters out.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014742#comment-16014742 ] 

ASF GitHub Bot commented on ORC-193:
------------------------------------

GitHub user omalley opened a pull request:

    https://github.com/apache/orc/pull/124

    ORC-193. Refactor TreeWriter API in WriterImpl.

    For this patch, I decided to just fix the API to TreeWriter. I'll make a follow up patch that just pulls the TreeWriter classes out of WriterImpl.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/omalley/orc orc-193

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124
    
----
commit 3d64ed5a5d047635e5c29d7545995001df260c5f
Author: Owen O'Malley <om...@apache.org>
Date:   2017-05-17T20:52:12Z

    ORC-193. Refactor TreeWriter API in WriterImpl.

----


> Refactor WriterImp to move TreeWriters out.
> -------------------------------------------
>
>                 Key: ORC-193
>                 URL: https://issues.apache.org/jira/browse/ORC-193
>             Project: ORC
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>
> We need to do some cleanup of WriterImpl to make some of the other changes like ORC-14 easier. I'd like to make a TreeWriter interface and make the current base class TreeWriterBase. At the same time, I'd like to move them to org.apache.orc.impl.writer as separate classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)