You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by august782 <gi...@git.apache.org> on 2016/06/18 22:41:08 UTC
[GitHub] commons-cli pull request #4: Removing unnecessary subclassing of DefaultPars...
GitHub user august782 opened a pull request:
https://github.com/apache/commons-cli/pull/4
Removing unnecessary subclassing of DefaultParserTest
The test class BugCLI252Test extends DefaultParserTest, but there is no need for it to do so as it does not use anything from DefaultParserTest. Currently, with this inheritance, 58 tests from DefaultParserTest are run unnecessarily (as they are already run by DefaultParserTest). By removing the inheritance, 58 fewer tests need to be run when testing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/august782/commons-cli trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-cli/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 28212b3851f715a8ce586c2fd6152f77dfdba4cb
Author: August Shi <aw...@illinois.edu>
Date: 2016-06-18T22:38:02Z
Removing unnecessary subclassing of DefaultParserTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-cli pull request #4: Removing unnecessary subclassing of DefaultPars...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-cli/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org