[jira] [Commented] (TS-4930) Unfold request headers that are using obs continuations

["Alan M. Carroll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573040#comment-15573040 ] 

Alan M. Carroll commented on TS-4930:
-------------------------------------

After massive amounts of discussion I think the path forward is to provide an API mechanism to unfold values in the outgoing request, rather than handle it during the parse. While doing it during the parse is clearly more efficient, it's unclear that the performance difference will be noticeable in practice. The disadvantages are

* Breaking {{const}} on the parser API.
* Breaking the read only guarantee of {{IOBuffer}}.
* Providing no flexibility.

If this is done on the outbound request, only those values that require unfolding would be changed and the copies put in the header heap which should affordable. If at all possible the parser should mark fields that have folded lines to improve efficiency later, to avoid doing any checks on fields that are not folded (which should be the vast majority of the time).

> Unfold request headers that are using obs continuations
> -------------------------------------------------------
>
>                 Key: TS-4930
>                 URL: https://issues.apache.org/jira/browse/TS-4930
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: HTTP
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>             Fix For: 7.1.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> In RFC 7230, we have
> {code}
>    Header fields that span multiple lines ("line folding") are
>    deprecated.  (Section 3.2.4)
> {code}
> Our recommendation is to unfold these into a single line for now, possibly later add an option to make such request generate 40x errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)