You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/01/03 13:24:12 UTC
[GitHub] QiuMM commented on a change in pull request #6791: statsd-emitter:
support constant DogStatsD tags
QiuMM commented on a change in pull request #6791: statsd-emitter: support constant DogStatsD tags
URL: https://github.com/apache/incubator-druid/pull/6791#discussion_r244997579
##########
File path: extensions-contrib/statsd-emitter/src/main/java/org/apache/druid/emitter/statsd/StatsDEmitter.java
##########
@@ -53,7 +53,7 @@ static StatsDEmitter of(StatsDEmitterConfig config, ObjectMapper mapper)
config.getPrefix(),
config.getHostname(),
config.getPort(),
- EMPTY_ARRAY,
+ config.getDogstatsd() ? config.getDogstatsdConstantTags().toArray(new String[0]) : EMPTY_ARRAY,
Review comment:
For boolean field, I prefer it's `Getter` method like `isXXX`, so change the `StatsDEmitterConfig#getDogstatsd` to `StatsDEmitterConfig#isDogstatsd` would be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org