You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Nithya Janarthanan (Code Review)" <ge...@cloudera.org> on 2018/07/12 21:41:04 UTC
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10931
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Description:
tpcds-unmodified workload was added as a part of IMPALA-6819
This change allows tpcds-unmodified workload to be available
for single node perf run
Testing:
Ran single node perf run using the following parameters and the
test run was successful
--iterations 2 --scale 2 --table_formats "parquet/none" \
--num_impalads 1 --workload "tpcds-unmodified" \
--load --query_names "TPCDS-Q17.*" --start_minicluster
Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
---
M bin/single_node_perf_run.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/10931/4
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2812/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 7
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 17:17:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 7
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 20:29:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 17:11:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 6
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 17:12:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2811/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 6
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 17:12:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Description:
tpcds-unmodified workload was added as a part of IMPALA-6819.
This change allows tpcds-unmodified workload to be available
for the single node perf run.
Testing:
Ran single node perf run using the following parameters and the
test run was successful
--iterations 2 --scale 2 --table_formats "parquet/none" \
--num_impalads 1 --workload "tpcds-unmodified" \
--load --query_names "TPCDS-Q17.*" --start_minicluster
Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Reviewed-on: http://gerrit.cloudera.org:8080/10931
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/single_node_perf_run.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
Jim Apple: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 8
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
Patch Set 4:
(1 comment)
Thank you so much for taking a look at this!
http://gerrit.cloudera.org:8080/#/c/10931/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10931/4//COMMIT_MSG@10
PS4, Line 10: tpcds-unmodified workload was added as a part of IMPALA-6819
nits: period at end of both sentences.
"the" between "for" and "single", or call it by its filename, single_node_perf_run.py.
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 22:50:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Nithya Janarthanan (Code Review)" <ge...@cloudera.org>.
Nithya Janarthanan has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Description:
tpcds-unmodified workload was added as a part of IMPALA-6819.
This change allows tpcds-unmodified workload to be available
for the single node perf run.
Testing:
Ran single node perf run using the following parameters and the
test run was successful
--iterations 2 --scale 2 --table_formats "parquet/none" \
--num_impalads 1 --workload "tpcds-unmodified" \
--load --query_names "TPCDS-Q17.*" --start_minicluster
Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
---
M bin/single_node_perf_run.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/10931/7
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 7
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Nithya Janarthanan (Code Review)" <ge...@cloudera.org>.
Nithya Janarthanan has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Description:
tpcds-unmodified workload was added as a part of IMPALA-6819.
This change allows tpcds-unmodified workload to be available
for the single node perf run.
Testing:
Ran single node perf run using the following parameters and the
test run was successful
--iterations 2 --scale 2 --table_formats "parquet/none" \
--num_impalads 1 --workload "tpcds-unmodified" \
--load --query_names "TPCDS-Q17.*" --start_minicluster
Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
---
M bin/single_node_perf_run.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/10931/5
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 5
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Nithya Janarthanan (Code Review)" <ge...@cloudera.org>.
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10931/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10931/4//COMMIT_MSG@10
PS4, Line 10: tpcds-unmodified workload was added as a part of IMPALA-6819
> nits: period at end of both sentences.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 4
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 17:08:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10931 )
Change subject: IMPALA-7228: Add tpcds-unmodified to single-node-perf-run
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511661c586cd55e3240ccbea9c499b9c3fc98440
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 7
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 17:17:21 +0000
Gerrit-HasComments: No