[GitHub] trafficserver pull request #1473: Avoid forcing "proxied URL" in case of tra...

[ushachar <gi...@git.apache.org>]

Github user ushachar commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1473#discussion_r104184151
  
    --- Diff: proxy/http/HttpTransact.cc ---
    @@ -7845,10 +7845,12 @@ HttpTransact::build_request(State *s, HTTPHdr *base_request, HTTPHdr *outgoing_r
           DebugTxn("http_trans", "[build_request] adding target to URL for parent proxy");
           outgoing_request->set_url_target_from_host_field();
         }
    -  } else if (s->next_hop_scheme == URL_WKSIDX_HTTP || s->next_hop_scheme == URL_WKSIDX_HTTPS ||
    -             s->next_hop_scheme == URL_WKSIDX_WS || s->next_hop_scheme == URL_WKSIDX_WSS) {
    +  } else if (!(s->client_info.is_transparent && base_request->is_target_in_url()) &&
    --- End diff --
    
    It's not equivalent -- the additional () forces both terms to be evaluated (even if the first one is false)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---