You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/23 14:40:30 UTC
[GitHub] [skywalking-nodejs] tom-pytel opened a new pull request #31: Add PgPlugin - PosgreSQL
tom-pytel opened a new pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31
Some tweaks to the mysql plugin here as well. Will see about tests for both this and mysql plugins, maybe I will add them to this PR if I have time but if no then will have to be a separate one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zijin-m commented on a change in pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
zijin-m commented on a change in pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#discussion_r582477003
##########
File path: tests/plugins/mysql/docker-compose.yml
##########
@@ -0,0 +1,88 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+version: "3.8"
+
+services:
+ collector:
+ extends:
+ file: ../common/base-compose.yml
+ service: collector
+ networks:
+ - traveling-light
+
+ mysql:
+ environment:
+ MYSQL_ROOT_PASSWORD: "root"
+ MYSQL_DATABASE: "test"
+ ports:
+ - 3306:3306
+ volumes:
+ - ./init:/docker-entrypoint-initdb.d
+ healthcheck:
+ test: ["CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/3306"]
+ interval: 5s
+ timeout: 60s
+ retries: 120
+ image: "docker.io/mysql:latest"
Review comment:
[mysql issue](https://github.com/mysqljs/mysql/issues/2377) It seems that the npm package `mysql` can't support `mysql8` well. Trying to use a lower version should be successful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786665285
I officially give up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-784255089
> Hope the tests can be added ASAP
Yes, am trying for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-785985309
What about my problem of running tests locally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786691088
> I'm not a fan of VS Code so I don't know whether or not there is such plugin. But I may consider building that into the CI workflow (we have similar in skywalking-python repo) to diff the expected data when failure,
That would be good because for someone without your setup trying to find an error in these raw logs is problematic. Speaking of which, what is it that is failing now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-785980074
The failure reason seems to be very trivial
<img width="1791" alt="image" src="https://user-images.githubusercontent.com/15965696/109174633-f81c5f80-77bf-11eb-8de9-a265bc001c10.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-784254252
Hope the tests can be added ASAP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786681279
> I was actually using [WebStorm](https://www.jetbrains.com/webstorm/) to compare and eliminate those `not null`, `gt 0`, etc. and finally use `git diff` to generate the text diff
I wonder if there is a plugin for VSCode, because without it those logs are unreadable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786671732
I got this from the [GitHub Actions logs](https://github.com/apache/skywalking-nodejs/pull/31/checks?check_run_id=1987759286), open the raw logs and search `console.info`, and compare with the `expected.data.yaml` in this PR
```diff
@@ -33,9 +33,12 @@ segmentItems:
peer: not null
skipAnalysis: false
tags:
- - { key: http.url, value: 'http://server:5000/postgre' }
- - { key: http.method, value: GET }
- - { key: http.status.code, value: '200' }
+ - key: http.url
+ value: http://server:5000/postgre
+ - key: http.method
+ value: GET
+ - key: http.status.code
+ value: "200"
refs:
- parentEndpoint: ""
networkAddress: server:5000
@@ -52,20 +55,23 @@ segmentItems:
spanLayer: Database
startTime: gt 0
endTime: gt 0
- componentId: 22
+ componentId: 5
spanType: Exit
peer: postgres:5432
skipAnalysis: false
tags:
- - { key: db.type, value: PostgreSQL }
- - { key: db.instance, value: test }
- - { key: db.statement, value: SELECT * FROM "user" where name = 'u1' }
+ - key: db.type
+ value: PostgreSQL
+ - key: db.instance
+ value: test
+ - key: db.statement
+ value: SELECT * FROM `user` WHERE `name` = "u1"
- serviceName: client
segmentSize: 1
segments:
- segmentId: not null
spans:
- - operationName: /postgre
+ - operationName: /postgres
operationId: 0
parentSpanId: -1
spanId: 0
@@ -77,10 +83,13 @@ segmentItems:
peer: not null
skipAnalysis: false
tags:
- - { key: http.url, value: 'http://localhost:5001/postgre' }
- - { key: http.method, value: GET }
- - { key: http.status.code, value: '200' }
- - operationName: /postgre
+ - key: http.url
+ value: http://localhost:5001/postgres
+ - key: http.method
+ value: GET
+ - key: http.status.code
+ value: "200"
+ - operationName: /postgres
operationId: 0
parentSpanId: 0
spanId: 1
@@ -92,7 +101,11 @@ segmentItems:
peer: server:5000
skipAnalysis: false
tags:
- - { key: http.url, value: 'server:5000/postgre' }
- - { key: http.method, value: GET }
- - { key: http.status.code, value: '200' }
- - { key: http.status.msg, value: OK }
+ - key: http.url
+ value: server:5000/postgres
+ - key: http.method
+ value: GET
+ - key: http.status.code
+ value: "200"
+ - key: http.status.msg
+ value: OK
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-785986275
> What about my problem of running tests locally?
From the logs, I suspect you may be running a rather old-version docker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786560896
Note that this doesn't have the postgre test yet, will add before merge if sql test runs ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786537649
> Service 'server' failed to build: The command '/bin/sh -c npm install request && npm install' returned a non-zero code: 1
I have encountered this sometimes when my network speed is slow.
> Also, 17 minutes to test 4 simple plugins?
This depends on many factors, the network speed, the spec of the machine, etc., but usually, I only run the one test that I'm concerned of, e.g. `npm run test tests/plugins/mysql`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786687905
> > I was actually using [WebStorm](https://www.jetbrains.com/webstorm/) to compare and eliminate those `not null`, `gt 0`, etc. and finally use `git diff` to generate the text diff
>
> I wonder if there is a plugin for VSCode, because without it those logs are unreadable.
I'm not a fan of VS Code so I don't know whether or not there is such plugin. But I may consider building that into the CI workflow (we have similar in skywalking-python repo) to diff the expected data when failure,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-785988247
> From the logs, I suspect you may be running a rather old-version docker?
```
tom@tom-VirtualBox:~/src/revdebugjs/skywalking-nodejs {master} $ docker --version
Docker version 20.10.3, build 48d30b5
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786680129
> > I got this from the [GitHub Actions logs](https://github.com/apache/skywalking-nodejs/pull/31/checks?check_run_id=1987759286), open the raw logs and search `console.info`, and compare with the `expected.data.yaml` in this PR
>
> Ok, what tool are you using to diff visualize this?
I was actually using [WebStorm](https://www.jetbrains.com/webstorm/) to compare and eliminate those `not null`, `gt 0`, etc. and finally use `git diff` to generate the 👆 text diff
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786676839
> I got this from the [GitHub Actions logs](https://github.com/apache/skywalking-nodejs/pull/31/checks?check_run_id=1987759286), open the raw logs and search `console.info`, and compare with the `expected.data.yaml` in this PR
Ok, what tool are you using to diff visualize this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on a change in pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on a change in pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#discussion_r582751889
##########
File path: tests/plugins/mysql/docker-compose.yml
##########
@@ -0,0 +1,88 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+version: "3.8"
+
+services:
+ collector:
+ extends:
+ file: ../common/base-compose.yml
+ service: collector
+ networks:
+ - traveling-light
+
+ mysql:
+ environment:
+ MYSQL_ROOT_PASSWORD: "root"
+ MYSQL_DATABASE: "test"
+ ports:
+ - 3306:3306
+ volumes:
+ - ./init:/docker-entrypoint-initdb.d
+ healthcheck:
+ test: ["CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/3306"]
+ interval: 5s
+ timeout: 60s
+ retries: 120
+ image: "docker.io/mysql:latest"
Review comment:
Yeah, the authentication thing, but no, I think its just the test writing sw logging to console, this requires @kezhenxu94 intervention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786722154
OH MY GOD!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786042915
> @tom-pytel can you change those version back to 2.1 and try again? I can reproduce this on a Ubuntu machine, though with different error message
2.1, the errors are different but still erroring. Also, 17 minutes to test 4 simple plugins?
```
FAIL tests/plugins/mysql/test.ts (933.259 s)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/mysql/test.ts
Creating network "testcontainers-61d5207f762731b72fc2a68e41ebe3a9_traveling-light" with the default driver
Building collector
Image for service collector was built because it did not already exist. To rebuild this image you must use `docker-compose build` or `docker-compose up --build`.
Pulling mysql (docker.io/mysql:5.7.33)...
Get https://registry-1.docker.io/v2/library/mysql/manifests/sha256:853105ad984a9fe87dd109be6756e1fbdba8b003b303d88ac0dda6b455f36556: net/http: TLS handshake timeout
at node_modules/testcontainers/dist/docker-compose-environment.js:189:15
at fulfilled (node_modules/testcontainers/dist/docker-compose-environment.js:24:58)
at runMicrotasks (<anonymous>)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/mysql/test.ts
connect ECONNREFUSED 127.0.0.1:5001
2021-02-25T16:41:36.150Z testcontainers ERROR Failed to start DockerCompose environment: Creating network "testcontainers-53a586624c68a4aca6c99d79e6247822_traveling-light" with the default driver
Building collector
Image for service collector was built because it did not already exist. To rebuild this image you must use `docker-compose build` or `docker-compose up --build`.
Building server
Service 'server' failed to build: The command '/bin/sh -c npm install request && npm install' returned a non-zero code: 1
2021-02-25T16:41:36.150Z testcontainers INFO Downing DockerCompose environment
2021-02-25T16:41:36.894Z testcontainers INFO Downed DockerCompose environment
FAIL tests/plugins/express/test.ts (971.688 s)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/express/test.ts
Creating network "testcontainers-c481cfb7ca6a39b81b77b8fa108a7284_traveling-light" with the default driver
Building collector
Image for service collector was built because it did not already exist. To rebuild this image you must use `docker-compose build` or `docker-compose up --build`.
Building server
Service 'server' failed to build: The command '/bin/sh -c npm install request && npm install' returned a non-zero code: 1
at node_modules/testcontainers/dist/docker-compose-environment.js:189:15
at fulfilled (node_modules/testcontainers/dist/docker-compose-environment.js:24:58)
at runMicrotasks (<anonymous>)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/express/test.ts
connect ECONNREFUSED 127.0.0.1:5001
FAIL tests/plugins/axios/test.ts (974.59 s)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/axios/test.ts
Creating network "testcontainers-b66388486c6223686148ce4a19677f16_traveling-light" with the default driver
Building collector
Image for service collector was built because it did not already exist. To rebuild this image you must use `docker-compose build` or `docker-compose up --build`.
Building server
Service 'server' failed to build: The command '/bin/sh -c npm install request && npm install' returned a non-zero code: 1
at node_modules/testcontainers/dist/docker-compose-environment.js:189:15
at fulfilled (node_modules/testcontainers/dist/docker-compose-environment.js:24:58)
at runMicrotasks (<anonymous>)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/axios/test.ts
connect ECONNREFUSED 127.0.0.1:5001
FAIL tests/plugins/http/test.ts (1060.006 s)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/http/test.ts
Creating network "testcontainers-53a586624c68a4aca6c99d79e6247822_traveling-light" with the default driver
Building collector
Image for service collector was built because it did not already exist. To rebuild this image you must use `docker-compose build` or `docker-compose up --build`.
Building server
Service 'server' failed to build: The command '/bin/sh -c npm install request && npm install' returned a non-zero code: 1
at node_modules/testcontainers/dist/docker-compose-environment.js:189:15
at fulfilled (node_modules/testcontainers/dist/docker-compose-environment.js:24:58)
at runMicrotasks (<anonymous>)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/http/test.ts
connect ECONNREFUSED 127.0.0.1:5001
Test Suites: 4 failed, 4 total
Tests: 4 failed, 4 total
Snapshots: 0 total
Time: 1060.214 s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! skywalking-backend-js@0.2.0 test: `DEBUG=testcontainers* jest`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the skywalking-backend-js@0.2.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/tom/.npm/_logs/2021-02-25T16_43_37_124Z-debug.log
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786722275
Quick! Merge it before it breaks again!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-784344689
Well, I am not having much luck even running the baseline tests locally, so without that can't actually add any:
```
2021-02-23T16:42:59.490Z testcontainers WARN Failed to stop DockerCompose environment after failed start
FAIL tests/plugins/axios/test.ts (123.094 s)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/axios/test.ts
The Compose file './docker-compose.yml' is invalid because:
Unsupported config option for services.client: 'extends'
Unsupported config option for services.collector: 'extends'
Unsupported config option for services.server: 'extends'
services.server.depends_on contains an invalid type, it should be an array
services.client.depends_on contains an invalid type, it should be an array
at node_modules/testcontainers/dist/docker-compose-environment.js:189:15
at Generator.throw (<anonymous>)
at rejected (node_modules/testcontainers/dist/docker-compose-environment.js:25:65)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/axios/test.ts
connect ECONNREFUSED 127.0.0.1:5001
FAIL tests/plugins/express/test.ts (123.199 s)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/express/test.ts
The Compose file './docker-compose.yml' is invalid because:
Unsupported config option for services.client: 'extends'
Unsupported config option for services.collector: 'extends'
Unsupported config option for services.server: 'extends'
services.server.depends_on contains an invalid type, it should be an array
services.client.depends_on contains an invalid type, it should be an array
at node_modules/testcontainers/dist/docker-compose-environment.js:189:15
at Generator.throw (<anonymous>)
at rejected (node_modules/testcontainers/dist/docker-compose-environment.js:25:65)
● plugin tests › /home/tom/src/revdebugjs/skywalking-nodejs/tests/plugins/express/test.ts
connect ECONNREFUSED 127.0.0.1:5001
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#issuecomment-786003904
@tom-pytel can you change those version back to 2.1 and try again? I can reproduce this on a Ubuntu machine, though with different error message
https://github.com/apache/skywalking-nodejs/blob/1b9d8d77d66850cc73153e7b28257e78264ee063/tests/plugins/express/docker-compose.yml#L18
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on a change in pull request #31: Add PgPlugin - PosgreSQL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #31:
URL: https://github.com/apache/skywalking-nodejs/pull/31#discussion_r583531278
##########
File path: tests/plugins/mysql/init/init.sql
##########
@@ -0,0 +1,7 @@
+use test;
Review comment:
```suggestion
-- Licensed to the Apache Software Foundation (ASF) under one or more
-- contributor license agreements. See the NOTICE file distributed with
-- this work for additional information regarding copyright ownership.
-- The ASF licenses this file to You under the Apache License, Version 2.0
-- (the "License"); you may not use this file except in compliance with
-- the License. You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.
use test;
```
##########
File path: src/config/AgentConfig.ts
##########
@@ -60,6 +60,6 @@ export default {
Number.parseInt(process.env.SW_AGENT_MAX_BUFFER_SIZE as string, 10) : 1000,
ignoreSuffix: process.env.SW_IGNORE_SUFFIX ?? '.jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg',
traceIgnorePath: process.env.SW_TRACE_IGNORE_PATH || '',
- mysql_sql_parameters_max_length: Math.trunc(Math.max(0, Number(process.env.SW_MYSQL_SQL_PARAMETERS_MAX_LENGTH))) || 512,
+ sql_parameters_max_length: Math.trunc(Math.max(0, Number(process.env.SW_MYSQL_SQL_PARAMETERS_MAX_LENGTH))) || 512,
Review comment:
```suggestion
sql_parameters_max_length: Math.trunc(Math.max(0, Number(process.env.SW_SQL_SQL_PARAMETERS_MAX_LENGTH))) || 512,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org