You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2026/03/10 12:02:32 UTC
[PR] GH-49486: [CI][C++] Fix Meson build missing tensor extension sources [arrow]
WillAyd opened a new pull request, #49487:
URL: https://github.com/apache/arrow/pull/49487
## Summary
- Add `extension/tensor_internal.cc` and `extension/variable_shape_tensor.cc` to the `arrow_json` sources in `meson.build`
- Add `variable_shape_tensor.h` to installed headers in `extension/meson.build`
- These files were present in `CMakeLists.txt` but missing from the Meson build, causing undefined reference linker errors for `variable_shape_tensor()`, `IsPermutationTrivial()`, `IsPermutationValid()`, `ComputeStrides()`, and `SliceTensorBuffer()`
## Test plan
- [ ] Verify the Meson CI build passes without linker errors
* GitHub Issue: #49486
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49486: [CI][C++] Fix Meson build missing tensor extension sources [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #49487:
URL: https://github.com/apache/arrow/pull/49487#issuecomment-4034837172
Oh sorry about this one. I wasn't aware I had to update `meson.build` files. Will do next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49486: [CI][C++] Fix Meson build missing tensor extension sources [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49487:
URL: https://github.com/apache/arrow/pull/49487#issuecomment-4030887878
:warning: GitHub issue #49486 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49486: [CI][C++] Fix Meson build missing tensor extension sources [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49487:
URL: https://github.com/apache/arrow/pull/49487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49486: [CI][C++] Fix Meson build missing tensor extension sources [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #49487:
URL: https://github.com/apache/arrow/pull/49487#issuecomment-4038626274
Not a big deal - Meson is a second tier of support. Seems like AI is pretty good at fixing these inconsistencies anyway, so its not a problem to just have it sweep the config now and again to pick these up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49486: [CI][C++] Fix Meson build missing tensor extension sources [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49487:
URL: https://github.com/apache/arrow/pull/49487#issuecomment-4035841265
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ca6845248b014db7131ba6dccec5f91b04b4543d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/66562339223) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org