You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/11/20 02:19:55 UTC
Review Request 40518: cleanup of SimpleMemoryAllocatorImpl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40518/
-----------------------------------------------------------
Review request for geode and Eric Shu.
Bugs: GEODE-580
https://issues.apache.org/jira/browse/GEODE-580
Repository: geode
Description
-------
remove unused classes from off-heap
move LifeCycleListener out of SimpleMemoryAllocatorImpl
move Chunk out of SimpleMemoryAllocatorImpl
move ChunkFactory out of SimpleMemoryAllocatorImpl
move GemFireChunkFactory out of SimpleMemoryAllocatorImpl
move ChunkType out of SimpleMemoryAllocatorImpl
move GemFireChunk out of SimpleMemoryAllocatorImpl
move GemFireChunkSlice out of SimpleMemoryAllocatorImpl
move ChunkWithHeapForm from SimpleMemoryAllocatorImpl
move DataAsAddress from SimpleMemoryAllocatorImpl
move Fragment from SimpleMemoryAllocatorImpl
move RefCountChangeInfo from SimpleMemoryAllocatorImpl
moved all LifeCycleListener static methods to that interface
move MemoryBlockNode from SimpleMemoryAllocatorImpl
move FakeChunk from SimpleMemoryAllocatorImpl
move SyncChunkStack from SimpleMemoryAllocatorImpl
move FreeListManager from SimpleMemoryAllocatorImpl
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImpl.java fd2a9441808714abb8b2d0e98b7db1414c32cb1a
gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/AbstractIndex.java 7ddacde0b2d39790409cebfe1c0c1dcd48d2a4e1
gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/DummyQRegion.java 1e1da4b9b47ce18737bc8e46704fbacda4236bb1
gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndex.java dd9cffd953dede8c3f26df6cb97cf5d79d59b1c6
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java f250bd2b0fed9a5d6bc0bc4ccf8e0ac3153e029d
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 80b55d5781c9d751d41fc4816de5f1ba2728f1d8
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BytesAndBitsForCompactor.java 8e466059f69ffeabfa0fa7d6cec2847cae0c101c
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 3973556cfa40d00b3db21b171c9fc47dcbff3c9c
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java 7295ad974deed27128c0fbeb890af1237fd28f8f
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 0786a69f7cff0d5255746245e2e1be9f0eb99290
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 190029782b195b08c5619dca138d0f2a78bcae86
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 29137fcc5ae5c914a8a26855bbead83ec1e21568
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinRegionEntry.java 6317fbce151fdbba3284dc1cd4f059a5d718a8c0
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java 6af005e05e8f8bdaa5c6a89c14e4033ee6b2c2f8
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java c4f0c87321766892809267ebbd3f5911ecc44a55
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Chunk.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkFactory.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkType.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkWithHeapForm.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/DataAsAddress.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/FakeChunk.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Fragment.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunk.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactory.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunkSlice.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/LifecycleListener.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryAllocator.java bf3808982a608d12fd4bdebdc35d4fbe55f1f768
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlock.java 05cc7967ee11f73a22e5d56190c7e1fc6358fa5c
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNode.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapCachedDeserializable.java 1bc2cdf957a8ba3b9ea4febc67e7f63c76079ddb
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 4fcacbf8accbed4796bca7552cf0c34a04fe9962
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/RefCountChangeInfo.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java c800335dade6c5ed94ed032ffa7264c4967b93a2
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SyncChunkStack.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ByteBufferInputStream.java 85775693c439ae815f203dedff36e0bb964011d2
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ImmutableByteBufferInputStream.java 4f16c8aabd0676082e6d62eac99ee869fa1cef66
gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/BlobHelper.java 6665e5590b761aeccdb74d558baa4980354b8229
gemfire-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInputStream.java 66d4887f92309897d6a27a12f7897535368740bf
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ChunkValueWrapperJUnitTest.java 428b2052eebc383e2a3f222c77c15a804169f1d9
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OffHeapTestUtil.java 2fc3c82ada128f5d785915c778ca737137d17323
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OldValueImporterTestBase.java 727a59c180b52c710482a46da03abc2119fea823
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/ConcurrentBagJUnitTest.java 8bba8db51de1df0aa1ce7c0fa1570e588859cba2
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListOffHeapRegionJUnitTest.java 2d38a26f766779dc1ff11ac2e58fcf2bcb99439d
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java 73fb51daa996062e13adf0286f5e7feee8300bbe
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapValidationJUnitTest.java a47d42d911a5cc08ae284c79e124e2911ca1426e
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapWriteObjectAsByteArrayJUnitTest.java e19f4cb5c6aa94a20539d704e19231386bd5ce9a
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OldFreeListOffHeapRegionJUnitTest.java 3636c7913a96c8fd9f6dcf19b50ab8e161a8eda0
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternJUnitTest.java 745d2c037dd9dbcbf38324894c6c224a4dc41b2f
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java ea90bdc9271c041039ee9411eb3cbca07391f5ee
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorLifecycleListenerJUnitTest.java 38f969eae837dc9e5ccf49d6642ac68a4e407a2c
gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteBufferByteSourceJUnitTest.java b3a4ab5210114ba4226bf51ffcc4c734c1093fc1
gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteSourceJUnitTest.java d0e1986f039737479fdbdbdbbfe7ebc91dcde549
Diff: https://reviews.apache.org/r/40518/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 40518: cleanup of SimpleMemoryAllocatorImpl
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40518/#review107629
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Shu
On Nov. 20, 2015, 1:19 a.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40518/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 1:19 a.m.)
>
>
> Review request for geode and Eric Shu.
>
>
> Bugs: GEODE-580
> https://issues.apache.org/jira/browse/GEODE-580
>
>
> Repository: geode
>
>
> Description
> -------
>
> remove unused classes from off-heap
> move LifeCycleListener out of SimpleMemoryAllocatorImpl
> move Chunk out of SimpleMemoryAllocatorImpl
> move ChunkFactory out of SimpleMemoryAllocatorImpl
> move GemFireChunkFactory out of SimpleMemoryAllocatorImpl
> move ChunkType out of SimpleMemoryAllocatorImpl
> move GemFireChunk out of SimpleMemoryAllocatorImpl
> move GemFireChunkSlice out of SimpleMemoryAllocatorImpl
> move ChunkWithHeapForm from SimpleMemoryAllocatorImpl
> move DataAsAddress from SimpleMemoryAllocatorImpl
> move Fragment from SimpleMemoryAllocatorImpl
> move RefCountChangeInfo from SimpleMemoryAllocatorImpl
> moved all LifeCycleListener static methods to that interface
> move MemoryBlockNode from SimpleMemoryAllocatorImpl
> move FakeChunk from SimpleMemoryAllocatorImpl
> move SyncChunkStack from SimpleMemoryAllocatorImpl
> move FreeListManager from SimpleMemoryAllocatorImpl
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImpl.java fd2a9441808714abb8b2d0e98b7db1414c32cb1a
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/AbstractIndex.java 7ddacde0b2d39790409cebfe1c0c1dcd48d2a4e1
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/DummyQRegion.java 1e1da4b9b47ce18737bc8e46704fbacda4236bb1
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndex.java dd9cffd953dede8c3f26df6cb97cf5d79d59b1c6
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java f250bd2b0fed9a5d6bc0bc4ccf8e0ac3153e029d
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 80b55d5781c9d751d41fc4816de5f1ba2728f1d8
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BytesAndBitsForCompactor.java 8e466059f69ffeabfa0fa7d6cec2847cae0c101c
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 3973556cfa40d00b3db21b171c9fc47dcbff3c9c
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java 7295ad974deed27128c0fbeb890af1237fd28f8f
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 0786a69f7cff0d5255746245e2e1be9f0eb99290
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 190029782b195b08c5619dca138d0f2a78bcae86
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 29137fcc5ae5c914a8a26855bbead83ec1e21568
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinRegionEntry.java 6317fbce151fdbba3284dc1cd4f059a5d718a8c0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java 6af005e05e8f8bdaa5c6a89c14e4033ee6b2c2f8
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java c4f0c87321766892809267ebbd3f5911ecc44a55
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Chunk.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkFactory.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkType.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkWithHeapForm.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/DataAsAddress.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/FakeChunk.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Fragment.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunk.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactory.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunkSlice.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/LifecycleListener.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryAllocator.java bf3808982a608d12fd4bdebdc35d4fbe55f1f768
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlock.java 05cc7967ee11f73a22e5d56190c7e1fc6358fa5c
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNode.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapCachedDeserializable.java 1bc2cdf957a8ba3b9ea4febc67e7f63c76079ddb
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 4fcacbf8accbed4796bca7552cf0c34a04fe9962
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/RefCountChangeInfo.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java c800335dade6c5ed94ed032ffa7264c4967b93a2
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SyncChunkStack.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ByteBufferInputStream.java 85775693c439ae815f203dedff36e0bb964011d2
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ImmutableByteBufferInputStream.java 4f16c8aabd0676082e6d62eac99ee869fa1cef66
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/BlobHelper.java 6665e5590b761aeccdb74d558baa4980354b8229
> gemfire-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInputStream.java 66d4887f92309897d6a27a12f7897535368740bf
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ChunkValueWrapperJUnitTest.java 428b2052eebc383e2a3f222c77c15a804169f1d9
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OffHeapTestUtil.java 2fc3c82ada128f5d785915c778ca737137d17323
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OldValueImporterTestBase.java 727a59c180b52c710482a46da03abc2119fea823
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/ConcurrentBagJUnitTest.java 8bba8db51de1df0aa1ce7c0fa1570e588859cba2
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListOffHeapRegionJUnitTest.java 2d38a26f766779dc1ff11ac2e58fcf2bcb99439d
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java 73fb51daa996062e13adf0286f5e7feee8300bbe
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapValidationJUnitTest.java a47d42d911a5cc08ae284c79e124e2911ca1426e
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapWriteObjectAsByteArrayJUnitTest.java e19f4cb5c6aa94a20539d704e19231386bd5ce9a
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OldFreeListOffHeapRegionJUnitTest.java 3636c7913a96c8fd9f6dcf19b50ab8e161a8eda0
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternJUnitTest.java 745d2c037dd9dbcbf38324894c6c224a4dc41b2f
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java ea90bdc9271c041039ee9411eb3cbca07391f5ee
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorLifecycleListenerJUnitTest.java 38f969eae837dc9e5ccf49d6642ac68a4e407a2c
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteBufferByteSourceJUnitTest.java b3a4ab5210114ba4226bf51ffcc4c734c1093fc1
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteSourceJUnitTest.java d0e1986f039737479fdbdbdbbfe7ebc91dcde549
>
> Diff: https://reviews.apache.org/r/40518/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>