[GitHub] gianm commented on a change in pull request #6757: Set is_available to false by default for published segment

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6757: Set is_available to false by default for published segment
URL: https://github.com/apache/incubator-druid/pull/6757#discussion_r242948288
 
 

 ##########
 File path: sql/src/test/java/org/apache/druid/sql/calcite/schema/SystemSchemaTest.java
 ##########
 @@ -330,10 +330,10 @@ public void testGetTableMap()
   public void testSegmentsTable() throws Exception
   {
     // total segments = 6
-    // segments 1,2,3 are published and available
-    // segments 4,5,6  are published but unavailable
-    // segment 3 is published but not served
-    // segment 2 is served by 2 servers, so num_replicas=2
+    // segments 1,2,3 are published but unavailable
+    // segments 4,5,6  are published and available
 
 Review comment:
   Something about this comment doesn't sound right. Segments _can be_ served by historicals but not be published. This happens when a segment has been marked unused in the metadata store, but hasn't been dropped from historicals yet. In the case of delays in dropping segments (for some reason: slowness, bugs, etc) this condition could stick around for a while, and in that case, we want the system table to reflect reality accurately to aid in diagnosis.
   
   So please add tests for this case too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org