You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangyum <gi...@git.apache.org> on 2017/06/04 14:43:19 UTC
[GitHub] spark pull request #18195: [SPARK-20921][SQL][WIP] Support can config Oracle...
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/18195
[SPARK-20921][SQL][WIP] Support can config OracleDialect whether convert number(1) to BooleanType
## What changes were proposed in this pull request?
Support can config OracleDialect whether convert number(1) to BooleanType, `autoConvertNumber2Boolean` default is `true`, set `false` to keep number(1) to IntegerType, usage:
```scala
val jdbcUrl = "jdbc:oracle:thin:@127.0.0.1:1521/test"
val props = new java.util.Properties()
props.put("user", "user")
props.put("password", "password")
props.put("driver", "oracle.jdbc.driver.OracleDriver")
props.put("autoConvertNumber2Boolean", "false")
val jdbcDF = spark.read.jdbc(jdbcUrl, "TableName", props)
jdbcDF.show()
```
## How was this patch tested?
unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangyum/spark SPARK-20921
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18195
----
commit febdf698f10730f01b368d1c99df088dcea29290
Author: Yuming Wang <wg...@gmail.com>
Date: 2017-06-04T14:21:36Z
Support OracleDialect whether convert number(1) to BooleanType
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18195: [SPARK-20921][SQL][WIP] Support can config OracleDialect...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18195
@vivekdixit05 I'm working on another PR https://github.com/apache/spark/pull/18266, That may be more general. I'll finish it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18195: [SPARK-20921][SQL][WIP] Support can config Oracle...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/18195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18195: [SPARK-20921][SQL][WIP] Support can config OracleDialect...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18195
**[Test build #77720 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77720/testReport)** for PR 18195 at commit [`febdf69`](https://github.com/apache/spark/commit/febdf698f10730f01b368d1c99df088dcea29290).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18195: [SPARK-20921][SQL][WIP] Support can config OracleDialect...
Posted by vivekdixit05 <gi...@git.apache.org>.
Github user vivekdixit05 commented on the issue:
https://github.com/apache/spark/pull/18195
Any updates on this, when and which version we can get this fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18195: [SPARK-20921][SQL][WIP] Support can config OracleDialect...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18195
**[Test build #77720 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77720/testReport)** for PR 18195 at commit [`febdf69`](https://github.com/apache/spark/commit/febdf698f10730f01b368d1c99df088dcea29290).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18195: [SPARK-20921][SQL][WIP] Support can config OracleDialect...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18195
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18195: [SPARK-20921][SQL][WIP] Support can config OracleDialect...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18195
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77720/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org