You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/01 16:11:35 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #24083: Reduce gird view API calls
bbovenzi opened a new pull request, #24083:
URL: https://github.com/apache/airflow/pull/24083
- Separate /grid_data from /grid
Let's make sure the page at least partially loads. And we avoid calling
- Remove need for formatData
This was taking a while in some benchmarks
- Update react-query query default options
Set a staleTime and change refetchOnMount from always to true (which only refetches when the data is stale)
- Fix useTask query keys
Some uses of useTask were using dagId as a key while others weren't causing double fetching
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24083: Reduce grid view API calls
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24083:
URL: https://github.com/apache/airflow/pull/24083#issuecomment-1143858435
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #24083: Reduce grid view API calls
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #24083:
URL: https://github.com/apache/airflow/pull/24083#discussion_r887031957
##########
airflow/www/static/js/grid/index.jsx:
##########
@@ -48,6 +48,7 @@ const queryClient = new QueryClient({
refetchOnWindowFocus: false,
retry: 1,
retryDelay: 500,
+ staleTime: 5 * 60 * 1000, // 5 minutes
Review Comment:
Correct. Setting `refetchInterval` ignores stale time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #24083: Reduce grid view API calls
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #24083:
URL: https://github.com/apache/airflow/pull/24083#discussion_r887031233
##########
airflow/www/static/js/grid/utils/gridData.js:
##########
@@ -17,18 +17,5 @@
* under the License.
*/
-import camelcaseKeys from 'camelcase-keys';
-
export const areActiveRuns = (runs = []) => runs.filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;
-
-export const formatData = (data, emptyData) => {
- if (!data || !Object.keys(data).length) {
- return emptyData;
- }
- let formattedData = data;
- // Convert to json if needed
- if (typeof data === 'string') formattedData = JSON.parse(data);
- // change from pascal to camelcase
- formattedData = camelcaseKeys(formattedData, { deep: true });
- return formattedData;
-};
+export const somethingElse = '';
Review Comment:
Oh, i forgot to push one commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #24083: Reduce grid view API calls
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #24083:
URL: https://github.com/apache/airflow/pull/24083#discussion_r887016507
##########
airflow/www/static/js/grid/index.jsx:
##########
@@ -48,6 +48,7 @@ const queryClient = new QueryClient({
refetchOnWindowFocus: false,
retry: 1,
retryDelay: 500,
+ staleTime: 5 * 60 * 1000, // 5 minutes
Review Comment:
Just to double check, this doesn't apply on refresh, right?
##########
airflow/www/static/js/grid/utils/gridData.js:
##########
@@ -17,18 +17,5 @@
* under the License.
*/
-import camelcaseKeys from 'camelcase-keys';
-
export const areActiveRuns = (runs = []) => runs.filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;
-
-export const formatData = (data, emptyData) => {
- if (!data || !Object.keys(data).length) {
- return emptyData;
- }
- let formattedData = data;
- // Convert to json if needed
- if (typeof data === 'string') formattedData = JSON.parse(data);
- // change from pascal to camelcase
- formattedData = camelcaseKeys(formattedData, { deep: true });
- return formattedData;
-};
+export const somethingElse = '';
Review Comment:
Was this intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #24083: Reduce grid view API calls
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #24083:
URL: https://github.com/apache/airflow/pull/24083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org