You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "mxm (via GitHub)" <gi...@apache.org> on 2023/05/09 18:35:53 UTC

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #585: [FLINK-32005] Add a per-deployment error metric to signal about potential issues

mxm commented on code in PR #585:
URL: https://github.com/apache/flink-kubernetes-operator/pull/585#discussion_r1188996818


##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java:
##########
@@ -82,8 +85,11 @@ public boolean scale(FlinkResourceContext<? extends AbstractFlinkResource<?, ?>>
 
         var conf = ctx.getObserveConfig();
         var resource = ctx.getResource();
+        var resouceId = ResourceID.fromResource(resource);
+        var autoscalerMetricGroup = ctx.getResourceMetricGroup().addGroup("AutoScaler");

Review Comment:
   Actually this one should probably just be added when the autoscaler is enabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org