You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2017/08/16 15:06:42 UTC

Re: Review Request 61678: Call HDFS Native authorizer with correct parameters in case of fall-back

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61678/
-----------------------------------------------------------

(Updated Aug. 16, 2017, 3:06 p.m.)


Review request for ranger and Madhan Neethiraj.


Bugs: RANGER-1181
    https://issues.apache.org/jira/browse/RANGER-1181


Repository: ranger


Description (updated)
-------

When Ranger cannot authorize the access request, and fallback to HDFS native authorizer is enabled, then native authorizer is invoked with incorrect parameter values for ancestorAccess, parentAccess, access or subAccess; instead of passing 'null' for these parameters when 'null' is provided in the original checkPermission() call, a value of FsAction:NONE is passed to native authorizer. This may cause the HDFS native authorizer to take a long time to authorize access, especially if the directory being authorized for access contains a large number of files/subdirectories.


Diffs (updated)
-----

  hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java f82fd57 


Diff: https://reviews.apache.org/r/61678/diff/2/

Changes: https://reviews.apache.org/r/61678/diff/1-2/


Testing
-------

Tested with local VM


Thanks,

Abhay Kulkarni


Re: Review Request 61678: Call HDFS Native authorizer with correct parameters in case of fall-back

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61678/#review183056
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 16, 2017, 3:06 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61678/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2017, 3:06 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-1181
>     https://issues.apache.org/jira/browse/RANGER-1181
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> When Ranger cannot authorize the access request, and fallback to HDFS native authorizer is enabled, then native authorizer is invoked with incorrect parameter values for ancestorAccess, parentAccess, access or subAccess; instead of passing 'null' for these parameters when 'null' is provided in the original checkPermission() call, a value of FsAction:NONE is passed to native authorizer. This may cause the HDFS native authorizer to take a long time to authorize access, especially if the directory being authorized for access contains a large number of files/subdirectories.
> 
> 
> Diffs
> -----
> 
>   hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java f82fd57 
> 
> 
> Diff: https://reviews.apache.org/r/61678/diff/2/
> 
> 
> Testing
> -------
> 
> Tested with local VM
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>