You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/01/04 19:35:10 UTC

Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review112612
-----------------------------------------------------------



docs/oversubscription.md (line 202)
<https://reviews.apache.org/r/41042/#comment173119>

    s/is ensuring/ensures/



docs/oversubscription.md (line 203)
<https://reviews.apache.org/r/41042/#comment173120>

    s/a configurable/configurable/



docs/oversubscription.md (line 204)
<https://reviews.apache.org/r/41042/#comment173121>

    s/controller/the `load` qos controller/



docs/oversubscription.md (line 333)
<https://reviews.apache.org/r/41042/#comment173122>

    s/will be/is/



docs/oversubscription.md (line 334)
<https://reviews.apache.org/r/41042/#comment173123>

    s/will be/is/
    
    s/then slave/the agent/


- Vinod Kone


On Dec. 8, 2015, 1:24 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 1:24 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-4076
>     https://issues.apache.org/jira/browse/MESOS-4076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added description to _Writing a custom QoS controller_ and _Configuring  oversubscription_ sections.
> 
> 
> Diffs
> -----
> 
>   docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f 
> 
> Diff: https://reviews.apache.org/r/41042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

Posted by Guangya Liu <gy...@gmail.com>.

> On 一月 4, 2016, 6:35 p.m., Vinod Kone wrote:
> > docs/oversubscription.md, line 204
> > <https://reviews.apache.org/r/41042/diff/2/?file=1155933#file1155933line204>
> >
> >     s/controller/the `load` qos controller/

s/controller/, the load qos controller/?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review112612
-----------------------------------------------------------


On 十二月 8, 2015, 1:24 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
> 
> (Updated 十二月 8, 2015, 1:24 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-4076
>     https://issues.apache.org/jira/browse/MESOS-4076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added description to _Writing a custom QoS controller_ and _Configuring  oversubscription_ sections.
> 
> 
> Diffs
> -----
> 
>   docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f 
> 
> Diff: https://reviews.apache.org/r/41042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

Posted by Bartek Plotka <bw...@gmail.com>.

> On Jan. 4, 2016, 6:35 p.m., Vinod Kone wrote:
> > docs/oversubscription.md, line 204
> > <https://reviews.apache.org/r/41042/diff/2/?file=1155933#file1155933line204>
> >
> >     s/controller/the `load` qos controller/
> 
> Guangya Liu wrote:
>     s/controller/, the load qos controller/?

@Guangya Liu: Agree (https://www.ego4u.com/en/cram-up/writing/comma?10)


- Bartek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review112612
-----------------------------------------------------------


On Dec. 8, 2015, 1:24 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 1:24 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-4076
>     https://issues.apache.org/jira/browse/MESOS-4076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added description to _Writing a custom QoS controller_ and _Configuring  oversubscription_ sections.
> 
> 
> Diffs
> -----
> 
>   docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f 
> 
> Diff: https://reviews.apache.org/r/41042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>