You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vemikhaylov (via GitHub)" <gi...@apache.org> on 2023/03/06 23:27:35 UTC
[GitHub] [airflow] vemikhaylov opened a new pull request, #29944: Fix tags selection in DAGs UI
vemikhaylov opened a new pull request, #29944:
URL: https://github.com/apache/airflow/pull/29944
The tags selection doesn't work for me without the fix (select2 on change event doesn't contain `val`, so the tags cannot be read from there).
Google Chrome: Version 109.0.5414.119 (Official Build) (x86_64)
jQuery v3.6.0
### Before:
https://user-images.githubusercontent.com/38596482/223279273-bbae473a-7828-4134-bf48-eeda965c7a1c.mov
### After:
https://user-images.githubusercontent.com/38596482/223279443-965adda9-783c-4f20-ada6-1c99568092de.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #29944: Fix tags selection in DAGs UI
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #29944:
URL: https://github.com/apache/airflow/pull/29944#discussion_r1128088111
##########
airflow/www/static/js/dags.js:
##########
@@ -61,9 +61,10 @@ $("#tags_filter").select2({
$("#tags_filter").on("change", (e) => {
e.preventDefault();
const query = new URLSearchParams(window.location.search);
- if (e.val.length) {
Review Comment:
This issue is because those tags are not actually on the page, so all we need to do is update this check, right?
`if (e.val && e.val.length) {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #29944: Fix tags selection in DAGs UI
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #29944:
URL: https://github.com/apache/airflow/pull/29944#issuecomment-1462861205
changing to 2.5.3 as 2.5.2 deadline has passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #29944: Fix tags selection in DAGs UI
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #29944:
URL: https://github.com/apache/airflow/pull/29944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org