You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/12 16:36:00 UTC
[jira] [Commented] (DRILL-6295) PartitionerDecorator may close
partitioners while CustomRunnable are active during query cancellation
[ https://issues.apache.org/jira/browse/DRILL-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435885#comment-16435885 ]
ASF GitHub Bot commented on DRILL-6295:
---------------------------------------
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1208
DRILL-6295: PartitionerDecorator may close partitioners while CustomRunnable are active during query cancellation
@ilooner Please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/drill DRILL-6295
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1208
----
commit 20c917461536d14bc752c3085fad8799a107f6cc
Author: Vlad Rozov <vr...@...>
Date: 2018-04-11T17:12:07Z
DRILL-6295: PartitionerDecorator may close partitioners while CustomRunnable are active during query cancellation
----
> PartitionerDecorator may close partitioners while CustomRunnable are active during query cancellation
> -----------------------------------------------------------------------------------------------------
>
> Key: DRILL-6295
> URL: https://issues.apache.org/jira/browse/DRILL-6295
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Critical
> Fix For: 1.14.0
>
>
> During query cancellation, in case {{PartitionerDecorator.executeMethodLogic()}} is active (waiting on the {{latch}}), the wait will be interrupted and {{Futures}} cancelled, but there is no guarantee that all {{CustomRunnable}} terminate before returning from {{PartitionerDecorator.executeMethodLogic()}}. On exit, both income and outgoing batches are cleared, leading to clearing of underlying {{Vectors}} and {{DrillBufs}}. This eventually causes unallocated memory access and JVM crash as {{CustomRunnable}} may execute after income/outgoing batches are cleared.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)