You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by Jukka Zitting <ju...@gmail.com> on 2006/09/09 09:07:38 UTC
Missing or incorrect license headers
Hi,
The following classes in Jackrabbit core have missing or incorrect
license headers. Please check and correct (original committer in
parenthesis):
* org.apache.jackrabbit.core.observation.ObservationManagerImpl (Marcel)
* org.apache.jackrabbit.core.lock.XAEnvironment (Dominique)
* org.apache.jackrabbit.core.query.lucene.SharedFieldSortComparator (Marcel)
BR,
Jukka Zitting
--
Yukatan - http://yukatan.fi/ - info@yukatan.fi
Software craftsmanship, JCR consulting, and Java development
Re: Missing or incorrect license headers
Posted by Edgar Poce <ed...@gmail.com>.
On 9/17/06, Jukka Zitting <ju...@gmail.com> wrote:
> Hi,
>
> On 9/9/06, Jukka Zitting <ju...@gmail.com> wrote:
> > The following classes in Jackrabbit core have missing or incorrect
> > license headers. Please check and correct (original committer in
> > parenthesis):
> >
> > * org.apache.jackrabbit.core.observation.ObservationManagerImpl (Marcel)
> > * org.apache.jackrabbit.core.lock.XAEnvironment (Dominique)
> > * org.apache.jackrabbit.core.query.lucene.SharedFieldSortComparator (Marcel)
>
> There's also one in jackrabbit-jca:
>
> * org.apache.jackrabbit.jca.JCAResourceAdapter (Edgar)
>
> Please check and correct. Alternatively I can go and add the license
> header, but only if you indicate that it's OK.
>
done, thanks for pointing it out.
br,
edgar
> Note that this issue is a blocker for 1.1.
>
> BR,
>
> Jukka Zitting
>
> --
> Yukatan - http://yukatan.fi/ - info@yukatan.fi
> Software craftsmanship, JCR consulting, and Java development
>
Re: Missing or incorrect license headers
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On 9/17/06, robert burrell donkin <ro...@gmail.com> wrote:
> also http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit/src/site/xdoc/doc/hops/FirstHop.java
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit/src/site/xdoc/doc/hops/SecondHop.java
> http://svn.apache.org/repos/asf/jackrabbit/trunk/contrib/tck-webapp/src/java/org/apache/jackrabbit/tck/TestResultParser.java
>
> jsps in http://svn.apache.org/repos/asf/jackrabbit/trunk/contrib/jcrtaglib/src/examples/web/
>
> numerous ddls, package.htmls, .properties and some xml files don't
> have license headers (can provide details).
Hmm, good point. I've so far concentrated on the release packages
(outside contrib) and the Java source files in src/main and src/test,
but you're right that the other files should also carry license
headers.
A quick grep with some filtering over the Jackrabbit core produced the
below list of files without the license header.
There are a number of image files included in the source tree. I
haven't seen a policy for using watermarks or exif fields for license
notices, so I think the images are cool for now.
We also have a few files (the XPath grammar) under W3C license. I
suppose we should add an entry about that in the NOTICE file.
In fact I'll open a Jira issue for tracking this... :-)
BR,
Jukka Zitting
./applications/test/repository/namespaces/ns_reg.properties.install
./applications/test/workspaces/test/workspace.xml
./applications/test/workspaces/default/workspace.xml
./applications/test/xsd-converter-model-output.cnd
./applications/test/cnd-reader-test-input.cnd
./applications/test/jaas.config
./applications/test/log4j.properties
./applications/test/repository.xml
./applications/test/repositoryStubImpl.properties
./applications/test/xsd-converter-test-input.xsd
./src/main/config/log4j.properties
./src/main/config/jaas.config
./src/main/config/repository.xml
./src/main/java/org/apache/jackrabbit/core/config/package.html
./src/main/java/org/apache/jackrabbit/core/fs/db/daffodil.ddl
./src/main/java/org/apache/jackrabbit/core/fs/db/db2.ddl
./src/main/java/org/apache/jackrabbit/core/fs/db/default.ddl
./src/main/java/org/apache/jackrabbit/core/fs/db/derby.ddl
./src/main/java/org/apache/jackrabbit/core/fs/db/mssql.ddl
./src/main/java/org/apache/jackrabbit/core/fs/db/mysql.ddl
./src/main/java/org/apache/jackrabbit/core/fs/db/package.html
./src/main/java/org/apache/jackrabbit/core/fs/db/postgresql.ddl
./src/main/java/org/apache/jackrabbit/core/fs/db/oracle.ddl
./src/main/java/org/apache/jackrabbit/core/lock/XAEnvironment.java
./src/main/java/org/apache/jackrabbit/core/nodetype/test.xml
./src/main/java/org/apache/jackrabbit/core/nodetype/builtin_nodetypes.cnd
./src/main/java/org/apache/jackrabbit/core/observation/ObservationManagerImpl.java
./src/main/java/org/apache/jackrabbit/core/query/lucene/SharedFieldSortComparator.java
./src/main/java/org/apache/jackrabbit/core/state/db/postgresql.ddl
./src/main/java/org/apache/jackrabbit/core/state/db/daffodil.ddl
./src/main/java/org/apache/jackrabbit/core/state/db/db2.ddl
./src/main/java/org/apache/jackrabbit/core/state/db/default.ddl
./src/main/java/org/apache/jackrabbit/core/state/db/derby.ddl
./src/main/java/org/apache/jackrabbit/core/state/db/mssql.ddl
./src/main/java/org/apache/jackrabbit/core/state/db/mysql.ddl
./src/main/java/org/apache/jackrabbit/core/state/db/package.html
./src/main/java/org/apache/jackrabbit/core/state/db/oracle.ddl
./src/main/java/org/apache/jackrabbit/core/version/package.html
./src/main/java/org/apache/jackrabbit/core/package.html
./src/main/java/org/apache/jackrabbit/core/repository.xml
./src/main/java/org/apache/jackrabbit/core/test-repository.xml
./src/main/java/org/apache/jackrabbit/uuid/package.html
./src/site/xdoc/doc/hops/SecondHop.java
./src/site/xdoc/doc/hops/log4j.properties
./src/site/xdoc/doc/hops/FirstHop.java
./src/site/xdoc/style/project.css
./src/site/xdoc/style/print.css
./src/site/xdoc/tasks.xml
./src/site/xdoc/doap_Jackrabbit.rdf
./src/test/java/org/apache/jackrabbit/core/config/repository.xml
./src/test/java/org/apache/jackrabbit/core/config/workspace.xml
./src/test/java/org/apache/jackrabbit/core/nodetype/xml/test_ns_cnd_nodetypes.cnd
./checkstyle-suppressions.xml
./derby.properties
./jdepend.properties
Re: Missing or incorrect license headers
Posted by robert burrell donkin <ro...@gmail.com>.
On 9/17/06, Jukka Zitting <ju...@gmail.com> wrote:
> Hi,
>
> On 9/9/06, Jukka Zitting <ju...@gmail.com> wrote:
> > The following classes in Jackrabbit core have missing or incorrect
> > license headers. Please check and correct (original committer in
> > parenthesis):
> >
> > * org.apache.jackrabbit.core.observation.ObservationManagerImpl (Marcel)
> > * org.apache.jackrabbit.core.lock.XAEnvironment (Dominique)
> > * org.apache.jackrabbit.core.query.lucene.SharedFieldSortComparator (Marcel)
>
> There's also one in jackrabbit-jca:
>
> * org.apache.jackrabbit.jca.JCAResourceAdapter (Edgar)
also http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit/src/site/xdoc/doc/hops/FirstHop.java
http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit/src/site/xdoc/doc/hops/SecondHop.java
http://svn.apache.org/repos/asf/jackrabbit/trunk/contrib/tck-webapp/src/java/org/apache/jackrabbit/tck/TestResultParser.java
jsps in http://svn.apache.org/repos/asf/jackrabbit/trunk/contrib/jcrtaglib/src/examples/web/
numerous ddls, package.htmls, .properties and some xml files don't
have license headers (can provide details).
- robert
Re: Missing or incorrect license headers
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On 9/9/06, Jukka Zitting <ju...@gmail.com> wrote:
> The following classes in Jackrabbit core have missing or incorrect
> license headers. Please check and correct (original committer in
> parenthesis):
>
> * org.apache.jackrabbit.core.observation.ObservationManagerImpl (Marcel)
> * org.apache.jackrabbit.core.lock.XAEnvironment (Dominique)
> * org.apache.jackrabbit.core.query.lucene.SharedFieldSortComparator (Marcel)
There's also one in jackrabbit-jca:
* org.apache.jackrabbit.jca.JCAResourceAdapter (Edgar)
Please check and correct. Alternatively I can go and add the license
header, but only if you indicate that it's OK.
Note that this issue is a blocker for 1.1.
BR,
Jukka Zitting
--
Yukatan - http://yukatan.fi/ - info@yukatan.fi
Software craftsmanship, JCR consulting, and Java development