You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2019/07/31 15:06:32 UTC
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13966
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
IMPALA-8636: fix flakiness of ACID INSERT tests
I had to add @UniqueDatabase.parametrize(sync_ddl=True) to some e2e
tests because without it Impala sometimes didn't see the newly
created uqniue database.
Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
---
M tests/query_test/test_insert.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/13966/1
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13966 )
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 11:07:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13966 )
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 11:06:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13966 )
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13966/3/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/13966/3/tests/metadata/test_hms_integration.py@34
PS3, Line 34: from tests.common.parametrize import UniqueDatabase
flake8: F401 'tests.common.parametrize.UniqueDatabase' imported but unused
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 15:27:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13966 )
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
IMPALA-8636: fix flakiness of ACID INSERT tests
I had to add @UniqueDatabase.parametrize(sync_ddl=True) to some e2e
tests because they were broken in exhaustive mode. When the tests run
with sync_ddl=True then the test files are executed against multiple
impalads which means that each statement in the .test file is executed
against a random impalad.
Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Reviewed-on: http://gerrit.cloudera.org:8080/13966
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_insert.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13966 )
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4716/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 11:07:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13966
to look at the new patch set (#3).
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
IMPALA-8636: fix flakiness of ACID INSERT tests
I had to add @UniqueDatabase.parametrize(sync_ddl=True) to some e2e
tests because they were broken in exhaustive mode. When the tests run
with sync_ddl=True then the test files are executed against multiple
impalads which means that each statement in the .test file is executed
against a random impalad.
Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
---
M tests/metadata/test_hms_integration.py
M tests/query_test/test_insert.py
2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/13966/3
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13966 )
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4103/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 15:42:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13966
to look at the new patch set (#2).
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
IMPALA-8636: fix flakiness of ACID INSERT tests
I had to add @UniqueDatabase.parametrize(sync_ddl=True) to some e2e
tests because without it Impala sometimes didn't see the newly
created uqniue database.
Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
---
M tests/metadata/test_hms_integration.py
M tests/query_test/test_insert.py
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/13966/2
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13966
to look at the new patch set (#4).
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
IMPALA-8636: fix flakiness of ACID INSERT tests
I had to add @UniqueDatabase.parametrize(sync_ddl=True) to some e2e
tests because they were broken in exhaustive mode. When the tests run
with sync_ddl=True then the test files are executed against multiple
impalads which means that each statement in the .test file is executed
against a random impalad.
Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
---
M tests/query_test/test_insert.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/13966/4
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13966 )
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 17:44:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13966 )
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4101/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 15:26:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13966 )
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4102/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 15:52:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13966 )
Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4104/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic724e77833ed9ea58268e1857de0d33f9577af8b
Gerrit-Change-Number: 13966
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 16:10:09 +0000
Gerrit-HasComments: No