You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2017/01/11 01:29:45 UTC
Re: Review Request 54408: Replaced `Master::Framework::active` with a
new `state` enum value.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54408/#review161163
-----------------------------------------------------------
Fix it, then Ship it!
Thanks for following through.
src/master/master.hpp (lines 2224 - 2239)
<https://reviews.apache.org/r/54408/#comment232401>
can you reorder these as so ?
RECOVERED,
DISCONNECTED,
INACTIVE,
ACTIVE
it's a bit more chronological but not really.
src/master/master.cpp (line 2914)
<https://reviews.apache.org/r/54408/#comment232402>
s/not connected/disconnected/
- Vinod Kone
On Dec. 7, 2016, 8:08 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54408/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 8:08 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6719
> https://issues.apache.org/jira/browse/MESOS-6719
>
>
> Repository: mesos
>
>
> Description
> -------
>
> That is, the master previously tracked two separate things about a
> framework: its "state" (CONNECTED, DISCONNECTED, or RECOVERED), and
> whether the framework is considered active. It is simpler to represent
> the latter value as just another state: a framework can now be ACTIVE,
> INACTIVE, DISCONNECTED, or RECOVERED. A framework is "connected" if it
> is either ACTIVE or INACTIVE. This rules out a few combinations that
> never made sense, such as "state = DISCONNECTED and active = TRUE".
>
>
> Diffs
> -----
>
> src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f
> src/master/master.hpp b444b2352360fb4f7179acd97dffc0cd81cc7afa
> src/master/master.cpp 67f32229470da4cf7953881d1c5dcb99393002de
> src/master/quota_handler.cpp 5578663f26d9b737499dc4f5a286c34c37645442
>
> Diff: https://reviews.apache.org/r/54408/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>